Joe Clinton

Results 182 comments of Joe Clinton

> I think I fixed all the folders compatibility bugs. Also made the duplicate item selecting code use React hacking instead of fake click events. > > Another unrelated bug...

> I haven't looked at the objects but a simple solution that should work most of the time would be checking if `asset.name` is `addon.tab.redux.state.locales.messages['gui.sharedMessages.costume'].replace('{index}', '1')` (and also check `gui.sharedMessages.backdrop`)...

I tested this more extensively and found no bugs when using the sprite folders addon. As far as I am aware this works as expected.

> > No dialog if I drag in a conflicting costume from the backpack > > Oof... nice catch RIP when this addon was less than 200 lines long As...

For sprite sorting a function exists similar to reorderSound or reorderCostume, it's called [reorderTarget](https://github.com/scratchfoundation/scratch-vm/blob/develop/src/virtual-machine.js#L1441).

Chatgpt thinks your natural sort can be done by using localCompare, which would make it alot more concise. Could you test? ```js Array.prototype.naturalSort = function() { return this.sort((a, b) =>...

> ok im pretty sure it works, sprites are done, the performance is actually really good, now just need to figure out how to close that menu See [here](https://github.com/scratchfoundation/scratch-gui/blob/34604ea3cf3ea511f1b2ed3b753023a4e325eb32/src/components/menu-bar/menu-bar.jsx#L272) You...

Has a bug ![image](https://github.com/ScratchAddons/ScratchAddons/assets/48254978/5c3b610b-1afb-4897-9c7b-0614db536a67) Edit Menu also doesn't close anymore when clicked. Might be caused by this bug.

> > The while loop which keeps checking if it isSorted is really questionable. You should just sort it once, then directly sort it with reorder, there's no need to...

I did the rewrite, seems to work now. Perhaps an option could be added to settings for descending vs ascending sort? Also the addon should be renamed to "sort assets...