Joe Clinton
Joe Clinton
Btw, anyone who does review please actually do some tests, to confirm that it works. Due to the way the code works there are many opportunities for bugs, and there...
> Could this also apply to sprites? The code for adding sounds and costumes are similar, but adding sprites uses an entirely different method. It would be alot of work....
> The dialog doesn't occur when dragging an asset from one sprite to another. This is probably Scratch just being useless and duplicating their code. I wrapped the base vm...
> When a costume called "costume1" exists, clicking on the "New Costume" button does this:  This also happens when dragging from the backpack. Basically...
> > This also happens when dragging from the backpack. Basically I have code which will look for the assets extension and concatenate that to the file name. There must...
> When choosing to Import and Replace, the replaced costume/sound isn't selected, but it is when selecting Import and Rename. Could it be selected there as well? Yes. I can...
> Was [48d23c6](https://github.com/ScratchAddons/ScratchAddons/commit/48d23c618639eb47b0967dc79b7be7b06484c935) supposed to do [#7232 (comment)](https://github.com/ScratchAddons/ScratchAddons/pull/7232#issuecomment-1966889173)? If so, it doesn't seem to do anything. It sets the costume just doesn't update the costumeTab state so you won't see...
There's absolutely no way i'm doing this for sprites too. Way too much work. For now just deleting the old sprite then importing the new one, should be the go...
> The only thing I can find missing is full compatibility with the folders addon. I made it a bit better, but the folders addon traps the RenderedTarget.addCostume/addSound that vm.addCostume/addSound...
@GarboMuffin ```js // finding the right item is made complicated by the folders addon const selectorItemsNumbers = tab.querySelectorAll("[class*='sprite-selector-item_number_']"); for (const selectorItemNumber of selectorItemsNumbers) { const index = +selectorItemNumber.textContent - 1;...