Joe Flood

Results 23 comments of Joe Flood

@jpn-- I've never done that before but I'd love to try. Would I just need to edit the settings.yaml file in the test subdirectory of one of the examples? For...

@jpn-- I had opened this pull request before Version 1.1 was released. Would it be better if I closed it and created a new one with the same changes applied...

The place to edit the random seed is in Line 64 of [core/config.py](https://github.com/ActivitySim/activitysim/blob/master/activitysim/core/config.py#L62) (Should this be configurable in the settings file?). However, setting that value to `None` results in an...

@jfdman @jpn-- @xiex0055 I looked through the source code and didn't find anywhere that reads the rng_base_seed value from the settings file (unless there's a way other than `config.setting()` that...

I added a test of the random number generator to the tests in actions. To test that I ran it using a version of the software that has that test...

@dhensle I have finished my review. Here are my comments: It might be good to add a check that `NUM_ESCORTEES` and `NUM_CHAPERONES` as defined in the settings file are consistent...

@dhensle Everything looks good to me. Thank you so much for your work on this!

Update: I tried compiling Sharrow where the only model step was initialize_landuse so that the only thing that would really be done was the skims would be converted to zarr....

I was finally able to get around to testing it on my end. It seemed to work just fine, though I did get the screenshotted error at the end. I'm...

@jpn-- I just reran the test on the same server using the same environment but setting `expression_profile: False` 1. That error didn't happen this time. If I recall correctly I've...