Joan Zapata

Results 60 comments of Joan Zapata

I agree, EdgeEffect actually didn't exist when I coded this lib. I'll probably do it when I'll have more time, pull request is welcome. :-)

Hi, do you mean the pdf file hasn't been downloaded entirely yet?

Oh I see, I didn't understand that the exception was coming from an AsyncTask, preventing you from catching it. I guess the error should delegated to an error handler that...

Nothing yet, you should be able to catch it using `Thread.setDefaultUncaughtExceptionHandler()` but it's bad. PR is welcome.

> public relations? [Pull Request](https://help.github.com/articles/using-pull-requests/) > why don't you just catch the exception and create a callback interface for the developer to catch the error? Because I don't have the...

Would be nice indeed, PR is welcome!

The library should create the appropriate file hierarchy [here](https://github.com/JoanZapata/android-pdfview/blob/master/android-pdfview/src/main/java/com/joanzapata/pdfview/util/FileUtils.java#L37) In the meantime, please use this code before you call `fromAsset(assetPath)`: ``` File outFile = new File(context.getCacheDir(), assetPath + "-pdfview.pdf"); outFile.getParent().mkdirs();...

Can you show me some screenshot so I can see what king of degradation you are talking about please?