Joe Turki
Joe Turki
> As a general rule, I'm suspicious of callbacks, I prefer direct style whenever possible, especially in Go. In this commit, you're adding a whole bunch of callbacks, so naturally...
@MikeRavenelle please try https://github.com/pion/dtls/releases/tag/v3.0.7 sorry we lost track of this!
@MikeRavenelle Did it work with v3.0.6, can you provide packet capture or a way to reproduce?
I'm not sure how that relates to #711 there is no SCSV in your cipher list for example. hmm, can you please open an issue and provide a way to...
Would it be possible to add a simple unit test for this? Thank you so much.
Hello, For this PR you can add tests here https://github.com/pion/webrtc/blob/master/peerconnection_media_test.go No need to mock the actual connections. For making RTP packets, there are some helpers exposed from pion/rtp, also there...
Sorry Kostya, I was busy and I lost track of this, This looks fine to me, I'll review it again by tomorrow, and I would like to leave it open...
@kvasilye Sorry the test is failing i forgot to report that when i reviewed it this weekend, my bad
@kvasilye Thank you so much, don't worry about the lint issues, we'll fix those ourselves when we merge it, I added it to the 4.2.0 milestone. I'll try to test...
@kvasilye Sorry about that, we usually merge minor improvements or bug fixes or opt-in changes fast, but this change affects the main path for the application and it affects the...