JmPotato comments

Results 59 comments of


                                            JmPotato

TiKV panic when push down min(set)

@HuSharp Would you like to take a look at this issue and fix it?

commands: use ReaderWithStats in flashback_to_version command

Please help review this small change, thx a lot! /cc @Connor1996 @sticnarf

storage: Rollback all locks to prevent from losing the pessimistic lock in flashback

/cc @Connor1996 @sticnarf PTAL, thx!

server, raftstore: check resolved ts when prepare the region flashback

/cc @Connor1996 @you06

server, raftstore: check resolved ts when prepare the region flashback

/hold

server, raftstore: check resolved ts when prepare the region flashback

/unhold

server, raftstore: check resolved ts when prepare the region flashback

Close this PR due to the implementation is out-of-date. Thx for your reviews @you06 @Connor1996.

Refine the flashback error handling

/cc @Defined2014 @sticnarf @Connor1996

Refine the flashback error handling

> > Signed-off-by: JmPotato [[email protected]](mailto:[email protected]) > > Since the flashback state check is before other checks like EpochNotMatch, so we need to invalidate the region cache also. > > Why...

Refine the flashback error handling

> It looks there is somethong wrong with integration test. Could you check why it is failing? I think it's the same problem as https://github.com/tikv/client-go/issues/449.