client-go icon indicating copy to clipboard operation
client-go copied to clipboard

Refine the flashback error handling

Open JmPotato opened this issue 3 years ago • 1 comments

Signed-off-by: JmPotato [email protected]

Since the flashback state check is before other checks like EpochNotMatch, so we need to invalidate the region cache also.

JmPotato avatar Oct 14 '22 09:10 JmPotato

/cc @Defined2014 @sticnarf @Connor1996

JmPotato avatar Oct 14 '22 09:10 JmPotato

It looks there is somethong wrong with integration test. Could you check why it is failing?

disksing avatar Oct 17 '22 08:10 disksing

Signed-off-by: JmPotato [email protected]

Since the flashback state check is before other checks like EpochNotMatch, so we need to invalidate the region cache also.

Why not move the order of the check after EpochNotMatch?

Connor1996 avatar Oct 17 '22 08:10 Connor1996

Signed-off-by: JmPotato [email protected] Since the flashback state check is before other checks like EpochNotMatch, so we need to invalidate the region cache also.

Why not move the order of the check after EpochNotMatch?

Good idea. I proposed a PR to do this, PTAL. https://github.com/tikv/tikv/pull/13618

JmPotato avatar Oct 17 '22 08:10 JmPotato

It looks there is somethong wrong with integration test. Could you check why it is failing?

I think it's the same problem as https://github.com/tikv/client-go/issues/449.

JmPotato avatar Oct 17 '22 08:10 JmPotato