JinmingHu

Results 57 comments of JinmingHu

We don't own C storage sdk

I don't care what `ReadToCount` returns, either `size_t` or `int64_t` looks good to me. You may also want to consider the arithmetic operations between the return type of `ReadToCount` and...

> OK, BodyStream functions that take a pointer to a buffer can use size_t for the count. > XxxClient functions that work with file sizes should take int64_t. > It...

We shouldn't use `FILE_FLAG_OVERLAPPED` here because we're expecting synchronous I/O operations. But it's not documented in the API reference what the behavior is to use overlapped read/write without `FILE_FLAG_OVERLAPPED` flag...

All right, so the read/write is not concurrent. We might be able to get some perf improvement with asynchronous I/O.

> > All right, so the read/write is not concurrent. > > How did you find out? What's the perf difference between this code path and the memory body stream...

related PR https://github.com/Azure/azure-sdk-for-cpp/pull/3618 https://github.com/Azure/azure-sdk-for-cpp/pull/3594 https://github.com/Azure/azure-sdk-for-cpp/pull/3742

@RickWinter Can you find somebody to answer this question? Thanks

Hi @RickWinter , can you take a look at this issue? It's been open for a month. Thanks

1. Delete blob 2. If you don't want to delete the blob, call GetBlockList, then CommitBlockList.