GMS-Feature-Matcher icon indicating copy to clipboard operation
GMS-Feature-Matcher copied to clipboard

Published 20 hours ago • verified publisher icon JiawangBian

Added draw matches to write text and no lines as mode=3.

Open mpkuse opened this issue 6 years ago • 5 comments

When there are a lot of matches it is hard to see the correct matches. So instead of lines, I draw circles and write text (serial number of the match) to the image. Basically, I have edited your DrawInlier().

mpkuse avatar Oct 31 '17 06:10 mpkuse

Hey mpkuse,

Thanks for your commits, and I would like to integrate it into the code. I give some suggestions before merging:

  1. Formatting the name of photos, as one may not understand the which pairs should be matched.
  2. Replacing "boost/timer" in cpp codes with the standard library for convenience, as many guys may not get boost library installed.
  3. I have invited Konrad who implemented the original python code to check out the change. He may give suggestions below about the python scripts.

Best, JiaWang

JiawangBian avatar Nov 02 '17 00:11 JiawangBian

Sure, I will follow your suggestion and add another commit soon.

mpkuse avatar Nov 02 '17 02:11 mpkuse

Hi mpkuse,

Thanks for your updates!

I have a few suggestions:

  1. Can you change syntax to match Python3? The script was originally developed to support it.
  2. Can you remove all unnecessary comments? I see quite a lot of code which is commented out.
  3. Can you write something more about GmsRobe, which is a new functionality? Did you invented it yourself or it's a implementation of known algorithm(if yes pleas provide a link where I could read more about it).

Best, Konrad

kczarnota avatar Nov 02 '17 10:11 kczarnota

What do you exactly mean by syntax to match python3?

I will get rid of the commented code. Basically, I added the main in a separate script and class in separate so that in my projects (and for others) can simply copy the class file and follow examples from demo.py file.

GmsRobe is my original work to extend the functionality. I will write a short readme for this.

I think I will need a couple of days to fix this up.

mpkuse avatar Nov 02 '17 10:11 mpkuse

I couldn't run your code because you use print function without parentheses. Please try to run your code with Python3 interpreter and it will tell you if there are any problems.

Take your time with changes, it's not a race :)

kczarnota avatar Nov 02 '17 13:11 kczarnota