Jiaqing Chen

Results 7 comments of Jiaqing Chen

> LGTM, thanks for your dedication to get this one going through the multiple modifications. Let me know if you are ready for this one to land, or you still...

> @Jiaqing-ASU if we find no obvious issue, the only think I can recommend is to update to the latest to both your main and this branch, copy the changed...

> @Jiaqing-ASU great, will review once #1683 has landed... thanks for working on this Please allow some time for me to modify some of the code in this PR after...

> updated the branch to run all cis @AlexandreEichenberger Thanks for the merge. I guess this will pass the tests since it works in my environment. However, this are still...

The "undefined symbol" issues have been fixed by making the new class a subclass of onnx_mlir::ExecutionSession instead of onnx_mlir::PyExecutionSession. It now works very well. However, for now, there are about...

> Gave you comments on the interface itself. Will review code a bit later No problem. Thanks for the helpful comments! I will fix all those comments one by one...

> I don't have access to a window machine; I usually try to see from the failure log, if one is lucky, it is a compile error that one can...