Jeremy Ruston
Jeremy Ruston
Thanks @pmario
Hi @twMat just to note the mechanism that we presently use for the "download" buttons saves the wiki with a subset of the current tiddlers (defined with a filter). It...
> Wouldn't it be better to use fetch() now. As things stand, the core sticks to ECMAScript 5 (which is now 10 years old!). When post-ES5 features accidentally get merged...
Hi @flibbles apologies for the delayed response. It's actually `hasVariable()` that is wrong. Originally, both `getVariable()` and `hasVariable()` both started looking in their own variables, and then up the ancestor...
Thanks @pmario looks good – I've added this to #8321
Thanks @pmario
Thanks @Leilei332 this is very encouraging, a decent size reduction and much better readability. Do you plan to refactor away the usages of these deprecated methods in this PR?
Hi @Leilei332 this is looking great, thank you. One small thing is that I think it would be helpful to adopt a more distinctive, searchable marker for deprecation comments. Something...
> I think we can use `@deprecated` JSDoc tag here, which is supported by VSCode and many tools. It also can pave the way for generating tiddlywiki js api docs...
Thanks @Leilei332