JeremyTCD
JeremyTCD
Sorry for the slow response. You could read from stdout: [I want to subscribe to events](https://github.com/JeringTech/Javascript.NodeJS/issues/130).
Ah you're right, the _numRetries = 0 case is not handled correctly. I'm thinking of making the following updates, together with your fix. Current: https://github.com/JeringTech/Javascript.NodeJS/blob/4c44c07a018e62d7c0c8fa4c9bfda60a0ad77afa/src/NodeJS/NodeJSServiceImplementations/OutOfProcess/OutOfProcessNodeJSServiceOptions.cs#L27-L40 Updated: ```diff + /// Renamed...
Yeah makes sense, appreciate the suggestion. Agree that retry logic should be extracted from `OutOfProcessNodeJSService`, and that it should be customizable. Also agree with conforming to framework norms. The main...
Okay thanks for all the tips. I took a look at your examples and tried using a `HttpClient` policy. Ran into a couple of issues: - Interactions with `OutOfProcessNodeJSService._connectingLock` complicate...
Hey! Interesting point. I've just taken a look at Jurassic's API, in particular `ScriptEngine`: ```csharp /// /// Executes the given source code. Execution is bound to the global scope. ///...
Thanks for the extra info ## Invoke Methods with Generic Parameters > For this case, you can implement the Undefined type as a structure. I'm not sure if I understood...
Okay, I believe we're on the same page. This will be a useful addition for those who want to return dynamic objects. Will tag you when I create the PR!
Hey you're right, there are some issues here. 1. We need a clearer exception message for when a return value is invalid. E.g if we're expecting an `int` and the...
Good point. I considered returning default values in such situations but it's tricky: This library doesn't manually parse values returned by scripts. Apart from `string`s and `stream`s, it serializes to...
Yeap agreed, it should be clearer. Leave this issue open for now, we'll close it when said improvements have been made.