Jeremy Rand
@kyuupichan What's the preferred way to test the Unix socket code? Tweak `FakeServer` to handle Unix sockets? Run an actual SOCKS proxy (e.g. Tor) on a Unix socket and connect...
Coveralls on Azure still seems unhappy about a missing token. :/
> git HEAD is not - as you can see from recent changes I've made - are you building on HEAD? I think so? This PR's parent commit is d3f5ac58f9d87ff917a04a9734d978e5821c4454....
ACK 80e7c00c0aa3da89ccc158555d8fe1222db00938
ACK e81c10c01ec3163a410818eb59be31aa3a75f06f. Can you remove the TODOs from the PR description before I merge (AFAICT they're all addressed now)?
> The `cli` currently lacks a `"pay invoice"` command. My plan is to focus on implementing for GUI exclusively, unless circumstances change. I think the `name_new` RPC command will work...
> > > The `cli` currently lacks a `"pay invoice"` command. My plan is to focus on implementing for GUI exclusively, unless circumstances change. > > > > > >...
> > The other thing we should probably do is, make the "Check name availability..." button check whether a name_new is already in the wallet for that name (by doing...
> If we make a separate the function, the password needs to be passed [here](https://github.com/robertmin1/electrum-nmc/blob/master/electrum_nmc/electrum/commands.py#L886) This would mean prompting the user to enter the password for every check name availability?...
Code review passes for f784cae4b4f8f3c4f4aee2c593603b5f9bb5da61 other than the things I noted above. Will test shortly.