Jenea Vranceanu

Results 57 comments of Jenea Vranceanu

> it seemed to not match signatures somewhere @richtera If so then we need to update it. I'll open a separate task to double-check that SIWE implementation matches the standard.

Sorry for the long waiting. Had more issues with tests. Now it's fixed and ready to be re-reviewed and potentially merged.

> `Sign` and Personal Sign` are very similar, can we merge it into one? Just add another checkbox under `Sign in with Ethereum`. I'll need to re-review this PR but...

> I guess this is stale - shall we close this one? @JeneaVranceanu I'll check and let you know.

> @JeneaVranceanu FYI this PR has been opened since last summer, should we merge? I'm moving the task to testing. I think we will merge tomorrow. It's kind of the...

SignTransaction component is already added. It's missing gasLimit, gasPrice, nonce, chainId, maxFeePerGas, maxPriorityFeePerGas fields. Located at `src/components/endpoints/SignTransaction.vue`.

> @KilianB do you still maintain this repo? @KilianB Wondering the same. I'm working on my own updated fork. I think it would be reasonable if I open a PR...