universalprofile-test-dapp icon indicating copy to clipboard operation
universalprofile-test-dapp copied to clipboard

feat: eth_signTransaction and personal_sign components

Open JeneaVranceanu opened this issue 1 year ago • 7 comments

https://app.clickup.com/t/86byuf8j1

Added support for eth_signTransaction and personal_sign.

  • personal_sign and eth_sign are now one component. The returned value must be the same as for eth_sign.
  • eth_signTransaction - visually it's a combination of eth_sendTransaction and eth_sign. This component sends a transaction to sign and allows for:
    • signer address recovery (same as eth_sign component);
    • signature validation through EIP1271.isValidSignature (same as eth_sign component);
    • checking if the signer has SIGN permission (just decided to add);

https://github.com/lukso-network/universalprofile-test-dapp/assets/36865532/fc99454f-5f11-49af-9b82-c50707121894

JeneaVranceanu avatar Aug 23 '23 15:08 JeneaVranceanu

Curious but should we upgrade the sign with ethereum stuff? I had looked at that before but it seemed to not match signatures somewhere

richtera avatar Aug 23 '23 18:08 richtera

it seemed to not match signatures somewhere

@richtera If so then we need to update it. I'll open a separate task to double-check that SIWE implementation matches the standard.

JeneaVranceanu avatar Aug 24 '23 06:08 JeneaVranceanu

Sorry for the long waiting. Had more issues with tests. Now it's fixed and ready to be re-reviewed and potentially merged.

JeneaVranceanu avatar Aug 29 '23 22:08 JeneaVranceanu

Sign and Personal Signare very similar, can we merge it into one? Just add another checkbox underSign in with Ethereum`.

I'll need to re-review this PR but yes, we can merge them into one.

JeneaVranceanu avatar Dec 05 '23 15:12 JeneaVranceanu

I guess this is stale - shall we close this one? @JeneaVranceanu

Hugoo avatar Apr 16 '24 18:04 Hugoo

I guess this is stale - shall we close this one? @JeneaVranceanu

I'll check and let you know.

JeneaVranceanu avatar Apr 16 '24 18:04 JeneaVranceanu

@JeneaVranceanu FYI this PR has been opened since last summer, should we merge?

franckwei avatar May 22 '24 15:05 franckwei

@JeneaVranceanu FYI this PR has been opened since last summer, should we merge?

I'm moving the task to testing. I think we will merge tomorrow. It's kind of the lowest priority 😅

JeneaVranceanu avatar May 22 '24 16:05 JeneaVranceanu