Ryan Neff

Results 11 comments of Ryan Neff

No, it only supports Choc v1. I don't think the V2 switches ever really caught on - to the point that there is no hotswap socket available for them. If...

It does not. The individual pcbs have traces for rows and columns only. The [MxLEDBitPCB](https://github.com/swanmatch/MxLEDBitPCB/blob/master/readme_en.md), however, is similar to the su120, and does support the delightful SK-6812 MINI-E. (The mini-e...

Great work! I'm looking forward to your findings. I'd really love to simplify things for the end user. I know a bunch of clones drift from spec - maybe we...

@waffle87 - thank you for the review! Changes applied.

@drashna & @waffle87 Thank you for the reviews - I've made the requested changes. Are there any other fixes needed?

@t-8ch > Wouldn't it be better to allocate a pid from https://pid.codes instead as that does not risk conflicts? Is there any official QMK guidance on this? It looks like...

> https://docs.qmk.fm/#/faq_build?id=usb-vid-and-pid > > I don't understand why sofle choc needs a different pair than the original sofle though? They have the same key layout etc. The Sofle Choc needs...

> There are plenty non-choc sofles with RGB. It would make more sense to me (presuming this is for VIA purposes) to edit the VIA json. There is one Sofle...

@t-8ch > Wouldn't it be better to allocate a pid from https://pid.codes instead as that does not risk conflicts? I followed up on this in the [QMK discord channel](https://discord.com/channels/440868230475677696/1215860348503064616/1215860348503064616). Using...

All issues have been addressed. Waiting for review.