Matthieu Riegler comments

Results 808 comments of


                                            Matthieu Riegler

fix(core): components marked for traversal resets reactive context

Presubmit is "green".

Unhandled promise rejections aren't properly reported in tests

The error is thrown asynchronously. If you want to catch it in a zonefull app, you'll need `fakeAsync`: ``` it('triggers an unhandled rejection', fakeAsync(() =>{ Promise.reject(new Error('test error')); })); ```...

Unhandled promise rejections aren't properly reported in tests

I took a deeper look into it. Up to v16, the test fails with an `Unhandled promise rejection`. (Everytime it's logged twice probably for the reason you already mentionned @atscott)...

Two levels of empty path children seems to break static redirects

Hi, could you please provide minimal working repro (either via a github repo or a stackblitz demo). That would help us investigate the issue thank you.

`@angular/builder:unit-test` doesn't support `fakeAsync`

Hi, you're repro repo is private.

refactor(common): remove redundant providedIn: 'root' from injection …

Caretake: This is a follow-up of #64802. A token with a factory is implictly providedIn in root unless specified otherwise

Aria entries have misleading infos:

We should probably show their selector in those cases because that realy what matters for them (+ the examples we already have)

fix(migrations): prevent duplicate imports in common-to-standalone migration

Looks like your change alters the import order in some of the tests, also 2 files need reformating. Can you PTAL.

feat(router): support for object in queryParams

Hi, before we have a look to this change can you make sure to sign the CLA, thank you.

fix(docs-infra): parse linenums attribute from triple ba…

Looks like we need a rebase again.