Matthieu Riegler
Matthieu Riegler
Could you add a corresponding unit test, thank you.
You while need to rebase your PR, drop the merge commits and squash everything into a single commit. We'd like this change to be a single commit. Thank you.
I'm suspecting that we're hitting a bug in `patch-package` `8.0.0` I regenerated the patch itself, but it won't apply and we get the error `**ERROR** Failed to apply patch for...
Hi, could you provide a minimal reprodcution example (under the form of a github repo for example), so we can have a look at it ? Thank you.
Without any reproduction, this isn't actionable to us.
Pullapprove is reporting that we miss 2 public-api scope approvals.
Effect isn't supposed to perfectly replace `ngOnChanges`. `ngOnChanges` (and `writeValue`) run as part of ChangeDectection of the parent component. In v19, effect will get executed just before the change detection...
Based on my previous comment, the current behavior is as designed.
We'll need you to [sign the CLA](https://github.com/angular/angular/pull/58170/checks?check_run_id=31419068373) to move forward with this PR. Thank you.