Matthieu Riegler

Results 631 comments of Matthieu Riegler

@alan-agius4 What would you think of adding `componentDef.type.name` to the hashSelectors to reduce collisions ? Would that still work even after minifiers ? That would fix @alexaka1's issue.

Not be stable as in non-consistant accross client-server ? Because that's what's important here.

Can I get https://github.com/angular/angular/labels/aio%3A%20preview thx !

@fortheday001 You want to run angular is the sharedWorker or having some code run in the shared worker in your angular App ?

@alfaproject You're making a goodpoint, the global definitions could be simplified now that IE has been dropped.

@dylhunn Following @alfaproject's comment, I change the scope of the PR to actually generalize the behaviour !

Yeah you're right. But they don't have any purpose since v11. So I was really wondering about their usage and if the 2 version depreciation period was necessary !

Hi ! Maybe mention that `takeUntilDestroyed` is still a developer preview ? (What's the reasionning behind not making it public when `DestroyRef ` is public btw ?)

Hi, your contribution still has some linting issues. See [the contributing guide](https://github.com/angular/angular/blob/main/CONTRIBUTING.md) to format your commit message as expected.