Matthieu Riegler comments

Results 686 comments of


                                            Matthieu Riegler

docs: update Dynamic Component loader docs to rely on `ngComponentOutlet`

@AndrewKushnir If you want to have a last look, the demo runs fine on stackblitz 👍🏻

refactor(compiler): Delete the `@angular/compiler/testing` module.

Actually I'm curious if it has some usage in G3.

refactor(compiler): Delete the `@angular/compiler/testing` module.

@atscott ✅

Use `Writable` utility type to improve typings

No interest for this change ? =)

Use `Writable` utility type to improve typings

@dylhunn Should be really straight forward 😊

Use `Writable` utility type to improve typings

The presubmit is failing, any info on what is breaking ?

feat(core): `ComponentMirror` exposes hostdirectives inputs/outputs

Thanks Joost, I also think this could land in a minor. I initially hesitated to include the host directive inputs into the component inputs. So I'm definitely open to it...

feat(core): `ComponentMirror` exposes hostdirectives inputs/outputs

Yes, It makes sense to consider the host directives as a private implementation detail ! PR is amended 👍

feat(core): `ComponentMirror` exposes hostdirectives inputs/outputs

@alxhub @pkozlowski-opensource Do you mind to take a look. Should we go forward on this or decline this PR ?

docs(localize): add warning about ICU not working with $localize, adap…

Hi, for you commit to be valid, you need to follow [the guidelines](https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit). In your case, you're missing the colon after the parenthesis !