Alessandro Lai

Results 270 comments of Alessandro Lai

They closed as "wont-fix", and I think that the new 2.0 release on our side will fix it anyway on DBAL 3, since we no longer need to hijack the...

We could try to use a decorator pattern instead of extension, but I'm not sure if everything that we need to accomplish is doable in that way...

Umh, this seems counter-intuitive, but avoiding extending `Doctrine\DBAL\Connection` is NOT doable, you get this error: ``` Doctrine\DBAL\Exception: The given 'wrapperClass' Facile\DoctrineMySQLComeBack\Doctrine\DBAL\FunctionalTest\Connection has to be a subtype of \Doctrine\DBAL\Connection. vendor/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:221 vendor/doctrine/dbal/lib/Doctrine/DBAL/DriverManager.php:195...

We should plan for a new major anyway, since DBAL 3.0 has too many breaking changes...

Wouldn't a major bump work as a nice "warning"? We would also get the nice side effect of releasing a future 3.0 compatible with DBAL 3.0.. :smile:

@thomasvargiu can you take a look at this? I'm off for the next weeks...

2.0 is not released yet. I prepared the readme for the release, but for now you can try it out by requiring `dev-master`. Please report back with feedback, since it's...

We're not sure, because we haven't really tested it in production yet. Can you report any result in that regard?

Thanks for reporting back @amigian74! I just tagged [2.0.0-BETA1](https://github.com/facile-it/doctrine-mysql-come-back/releases/tag/2.0.0-BETA1) (with no further changes), please use it and report back any issue you can find!

We happily accept PRs, if they will include adding the proper CI checks.