doctrine-mysql-come-back icon indicating copy to clipboard operation
doctrine-mysql-come-back copied to clipboard

Published 20 hours ago • verified publisher icon facile-it

WIP: Better code consistency

Open thomasvargiu opened this issue 3 years ago • 4 comments

Implemented required methods in ConnectionInterface used in  ConnectionTrait.

This could be considered a BC.

thomasvargiu avatar Apr 23 '21 12:04 thomasvargiu

We should plan for a new major anyway, since DBAL 3.0 has too many breaking changes...

Jean85 avatar Apr 23 '21 16:04 Jean85

Yes, in my mind this should be a fisr refactor in order to start writing a new version compatible with dbal v3 in order to make it easier to migrate. I'll try to make those changes.

thomasvargiu avatar Apr 26 '21 07:04 thomasvargiu

Working on it I was thinking that missed methods on ConnectionInterface can be considered a bug, because we always need those method implementations in our classes, implementations provided by the ConnectionTrait. Changing our implementations to use the new interface can be considered a BC Break too, because no user's ConnectionInterface implementations can be used anymore. It can be legit to me to just warn users that there is a possible BC Break in our minor release. @Jean85 What do you think?

thomasvargiu avatar Apr 26 '21 08:04 thomasvargiu

Wouldn't a major bump work as a nice "warning"? We would also get the nice side effect of releasing a future 3.0 compatible with DBAL 3.0.. :smile:

Jean85 avatar Apr 26 '21 08:04 Jean85

Closing since DBAL v2 is not dropped, and our v2 is nearly ready.

Jean85 avatar Apr 01 '23 21:04 Jean85