RoboticsAcademy
RoboticsAcademy copied to clipboard
JdeRobot
Pick & Place Exercise (Gazebo + Console + Rviz) with web-templates
I reproduced the branch on my system and the exercise works perfectly. Thanks Chandan (@predator4hack) for your contribution.
The number of changes in the current PR (1931) is daunting to review. Probably most of the changes are due to the static files of ace-builds for the website. Keeping those files for new exercise is a necessity I guess.
Maybe we can break the PR and get the raw template merged in JdeRobot:master first, in another PR, we can update changes specific to pick_place exercise. This way no. of changes in files would be less and code-review would be easier.
Also, the current docker build is from scratch, It took around 2 hours on my system for the build to complete.
Can we somehow use RoboticsAcademy current images as our Dockerfile's base image, and have a Dockerfile specifically to build the exercise? this way build time would be shorter I guess.
I reproduced the branch on my system and the exercise works perfectly. Thanks Chandan (@predator4hack) for your contribution.
The number of changes in the current PR (1931) is daunting to review. Probably most of the changes are due to the static files of ace-builds for the website. Keeping those files for new exercise is a necessity I guess.
Maybe we can break the PR and get the raw template merged in JdeRobot:master first, in another PR, we can update changes specific to
pick_placeexercise. This way no. of changes in files would be less and code-review would be easier.
Yeah, I guess we can do that
Also, the current docker build is from scratch, It took around 2 hours on my system for the build to complete.
Can we somehow use RoboticsAcademy current images as our Dockerfile's base image, and have a Dockerfile specifically to build the exercise? this way build time would be shorter I guess.
Yeah, we have multi-stage build for this. Once you create the base image for any version, you can build again on top of it. And you don't need to build the base image again and again, which takes most of the time.