vue-numeric-input icon indicating copy to clipboard operation
vue-numeric-input copied to clipboard

Update vue-numeric-input.vue

Open Trigur opened this issue 6 years ago • 2 comments

Fix NaN when value is empty

Trigur avatar Feb 05 '19 08:02 Trigur

Codecov Report

Merging #5 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files           1        1           
  Lines          56       56           
  Branches       16       16           
=======================================
  Hits           54       54           
  Partials        2        2
Impacted Files Coverage Δ
src/vue-numeric-input.vue 96.42% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d7a184...3b2e066. Read the comment docs.

codecov-io avatar Feb 05 '19 08:02 codecov-io

Why this is closed? I do not find the merge in master. In my opinion this resolves a valid issue with initial null values, as consequence you have to click twice on + or - initially. I tested this pull request successfully.

MartinKleikamp avatar Feb 28 '19 09:02 MartinKleikamp