Jason Weill

Results 566 comments of Jason Weill

@SarthakPaandey Sure, this is now assigned to you. Please reach out by leaving additional comments here if you have any questions or if you're ready for us to review a...

Related PR: #15155 would add a popover to show shortcuts when an accelerator is pressed. If we implement this, we need to avoid conflicts with the popover on keypress.

Removing the icons entirely makes the errors go away, although it also makes the layout of the extension manager look strange. Although the errors are worrying, many icons do in...

Using `curl`, when I fetch an avatar using `curl -v 'https://github.com/jasonweill.png'`, I see the SameSite attribute in the response: ``` < set-cookie: _gh_sess=[redacted]; Path=/; HttpOnly; Secure; SameSite=Lax ``` However, when...

@krassowski I spent some time earlier today looking into the GitHub API. It would yield the direct links to githubusercontent dot com that don't produce the same cookie warnings, but...

@doshi-kevin Your tests are still failing; you can see details inline here: https://github.com/jupyterlab/jupyterlab/pull/16706/files#diff-781a703e5af305446726c378a30e53a445113682c768180c073bc042837e0b14

I tried setting my runtime directory to `~/jason's-temp`, and when I started Lab 4.3.0 beta on macOS, `file:///Users/jweill/jason%27s-temp/jpserver-78401-open.html` was opened successfully (note URL escaping). With another test directory, a space...

This may be Windows-specific; need to try verifying on a Windows PC.

With JupyterLab 4.2.5, after setting `JUPYTER_RUNTIME_DIR` to a directory with an apostrophe and a space in it, I see an error on startup: ``` OSError: [WinError 123] The filename, directory...

On Windows, I also see "WinError 123" when the directory has an apostrophe and no space, or when the directory has a space and no apostrophe.