Jason Lunn

Results 81 comments of Jason Lunn

@JamesNK - you're being flagged for not having signed the CLA but having contributed to the last commit. Can you resolve that?

> I'm pretty sure I already have. When I click on the CLA details link I see this: > > ![image](https://private-user-images.githubusercontent.com/303201/375924261-48046ade-041e-477c-89a6-6a603461b928.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mjg3MzU4MjQsIm5iZiI6MTcyODczNTUyNCwicGF0aCI6Ii8zMDMyMDEvMzc1OTI0MjYxLTQ4MDQ2YWRlLTA0MWUtNDc3Yy04OWE2LTZhNjAzNDYxYjkyOC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQxMDEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MTAxMlQxMjE4NDRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hYjMwOTM4YWVkYzY5MWI4NDgyOTU3MDIxOWU4MzIxZGY2NTU1NWM3MGI5NzIzMGY2NGEyMGVjZmNkMGRiZjQ2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.A8d-5xom6HxpU2XukVSwzSKq7E_Y_zTBSZenRjnZ0T8) Can you check that the contact info matches `j***s​@newtonking.com`...

@PascalSenn - could you push a rebase? All the test failures are outside of the C# directory, I suspect their all due to drift with test targets given this PR's...

Interesting; this test exposes a behavior gap between the JRuby and JRuby FFI variants; the FFI-based implementation (with the passing test) uses the same C-based implementation under the hood, but...

> It seems latest version of protobuf in bcr are not using `maven` anymore in `bzlmod`(I can still see it in the WORKSPACE) and it leads to other set of...

> @bnordli, assuming you're using `bzlmod`, the examples list by @jschaf show you how to create a "private" set of dependencies for `protobuf`. If you were to do this, you...

If you send a PR I can get it routed to the right reviewers.

> @JasonLunn Did you mean to send this for review, or is this PR just for development? It can go back to development for now; I've sent https://github.com/protocolbuffers/build-support/pull/115 to @mkruskal-google...