Jason Lunn
Jason Lunn
I’ll look into what’s going on with binary gems. The source gem does not have an upper bound.
This PR will need to wait until someone on the Protobuf team can do the internal housekeeping to verify that the changes to `test_ruby.yml` work as expected, because the current...
Status update: Chasing down an issue with gem generation. Currently, everything works if the gem is build under an older version of Rubygems, but breaks under the latest version that...
See also the new tracking issue https://github.com/ruby/rubygems/issues/9244
Could you rebase this PR? Github thinks it is changing almost 800 files which makes review impractical. Edit, nevermind about the rebase. I see what @tonyliaoss means about the test...
> @JasonLunn how could I have the repo marked as "safe for tests" without having to request it for every commit? Humans have to apply the tag by policy for...
``` Failed FileDescriptor_CreateMessageWithDeepDependencies_BuildFromByteString [263 ms] Error Message: Expected: 402 But was: 419 Stack Trace: at Google.Protobuf.Reflection.DescriptorsTest.FileDescriptor_CreateMessageWithDeepDependencies_BuildFromByteString() in D:\a\protobuf\protobuf\csharp\src\Google.Protobuf.Test\Reflection\DescriptorsTest.cs:line 59 1) at Google.Protobuf.Reflection.DescriptorsTest.FileDescriptor_CreateMessageWithDeepDependencies_BuildFromByteString() in D:\a\protobuf\protobuf\csharp\src\Google.Protobuf.Test\Reflection\DescriptorsTest.cs:line 59 ``` Interestingly, this only fails...
It would expedite review if you could refactor the PR so that there are not ~800 files. I assume you have a script that generated the deeply nested test `.proto`...
I suspect that the test failures would be fixed with a rebase.
@sevaserg - is this still an issue for you on the latest release? It seems like @HisuianZoroark69 is reporting that it is working for them. It is also not clear...