Jaroslav Lobačevski

Results 89 comments of Jaroslav Lobačevski

Interesting... There are two versions of the tool https://www.nuget.org/packages/security-scan/ (5.0.1 is another bug, doh, need to fix in resources). Does it happen with both of them?

Looks like msbuid issue https://github.com/dotnet/msbuild/issues/6292 But some parts of the solution do not build with `dotnet build`. Meanwhile I have pushed an updated version https://www.nuget.org/packages/security-scan/5.1.1

@michaelnebel I was getting `Wrong number of columns in source model row, expected 9, got 8 in System.Net.Sockets;TcpClient;false;GetStream;;;ReturnValue;remote. |` so I have added `;manual` in attempt to fix that, now...

Finally, everything is green.

New merge conflicts appeared. I have revolved that. However I'm not sure about https://github.com/github/codeql/pull/9415/commits/6462423b7e91ff90a98567fef7e9efdb69f1dd31#diff-0bf160019833ad6f9c40ea33257e19a1945f2287468b4871f1064f2d0bc58ec1R114 I see that the imports were deleted in https://github.com/github/codeql/commit/582cfb93304783fa472e69cd56cf420ec1e50bc3 by @michaelnebel Hopefully it still works without...

It fails... @michaelnebel could you please suggest what is wrong?

All checks pass. Please review and merge as soon as it looks good. From the other pull request it seems there was a misunderstanding who should merge the PR as...

Oh, I didn't realize there is this file system restriction. Though it sounds like it should be easily fixable. I'll look into it next week.

My idea is to make all the files in the /tmp. That should work, shouldn't it?

Yes, the `die()` function is a major obstacle for fuzzing. This is why I added more places where it is commented out to the patch. Ok, so I didn't do...