codeql icon indicating copy to clipboard operation
codeql copied to clipboard

Published 20 hours ago • verified publisher icon github

Add TCP and UDP socket client taint sources

Open JarLob opened this issue 2 years ago • 10 comments

In order to support scenarios as:

            using (var tcpConn = new TcpClient("host.example.org", 39544))
            {
                /* read input from socket */
                using (StreamReader sr = new StreamReader(tcpConn.GetStream()))
                {
                    Sink(sr.ReadLine());
                }
            }

Also added StreamReader summary until MaD generator is fixed

JarLob avatar Jun 02 '22 10:06 JarLob

:warning: The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",3,12038,28,5
+    System,"``System.*``, ``System``",7,12050,28,5
-    Totals,,3,12599,359,5
+    Totals,,7,12611,359,5
  • Changes to framework-coverage-csharp.csv:
- package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:local,summary:taint,summary:value
+ package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:local,source:remote,summary:taint,summary:value
- Dapper,55,,,,,,55,,,,
+ Dapper,55,,,,,,55,,,,,
- JsonToItemsTaskFactory,,,7,,,,,,,7,
+ JsonToItemsTaskFactory,,,7,,,,,,,,7,
- Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,,,
- Microsoft.CSharp,,,24,,,,,,,24,
+ Microsoft.CSharp,,,24,,,,,,,,24,
- Microsoft.EntityFrameworkCore,6,,,,,,6,,,,
+ Microsoft.EntityFrameworkCore,6,,,,,,6,,,,,
- Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,15,
+ Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,15,
- Microsoft.Extensions.Caching.Memory,,,46,,,,,,,45,1
+ Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,45,1
- Microsoft.Extensions.Configuration,,,83,,,,,,,80,3
+ Microsoft.Extensions.Configuration,,,83,,,,,,,,80,3
- Microsoft.Extensions.DependencyInjection,,,62,,,,,,,62,
+ Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,62,
- Microsoft.Extensions.DependencyModel,,,12,,,,,,,12,
+ Microsoft.Extensions.DependencyModel,,,12,,,,,,,,12,
- Microsoft.Extensions.FileProviders,,,15,,,,,,,15,
+ Microsoft.Extensions.FileProviders,,,15,,,,,,,,15,
- Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,13,2
+ Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,13,2
- Microsoft.Extensions.Hosting,,,17,,,,,,,16,1
+ Microsoft.Extensions.Hosting,,,17,,,,,,,,16,1
- Microsoft.Extensions.Http,,,10,,,,,,,10,
+ Microsoft.Extensions.Http,,,10,,,,,,,,10,
- Microsoft.Extensions.Logging,,,37,,,,,,,37,
+ Microsoft.Extensions.Logging,,,37,,,,,,,,37,
- Microsoft.Extensions.Options,,,8,,,,,,,8,
+ Microsoft.Extensions.Options,,,8,,,,,,,,8,
- Microsoft.Extensions.Primitives,,,63,,,,,,,63,
+ Microsoft.Extensions.Primitives,,,63,,,,,,,,63,
- Microsoft.Interop,,,27,,,,,,,27,
+ Microsoft.Interop,,,27,,,,,,,,27,
- Microsoft.NET.Build.Tasks,,,1,,,,,,,1,
+ Microsoft.NET.Build.Tasks,,,1,,,,,,,,1,
- Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,4,
+ Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,4,
- Microsoft.VisualBasic,,,9,,,,,,,5,4
+ Microsoft.VisualBasic,,,9,,,,,,,,5,4
- Microsoft.Win32,,,8,,,,,,,8,
+ Microsoft.Win32,,,8,,,,,,,,8,
- MySql.Data.MySqlClient,48,,,,,,48,,,,
+ MySql.Data.MySqlClient,48,,,,,,48,,,,,
- Newtonsoft.Json,,,91,,,,,,,73,18
+ Newtonsoft.Json,,,91,,,,,,,,73,18
- ServiceStack,194,,7,27,,75,92,,,7,
+ ServiceStack,194,,7,27,,75,92,,,,7,
- System,28,3,12038,,4,,23,1,3,10096,1942
+ System,28,7,12050,,4,,23,1,3,4,10108,1942

github-actions[bot] avatar Jun 02 '22 10:06 github-actions[bot]

Question, since GetStream is a source of taint by itself are any changes to "System.Net.Sockets;TcpClient;false;GetStream;();;Argument[Qualifier];ReturnValue;generated:taint", in runtime.qll needed?

JarLob avatar Jun 02 '22 10:06 JarLob

:warning: The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",3,12038,28,5
+    System,"``System.*``, ``System``",7,12050,28,5
-    Totals,,3,12599,359,5
+    Totals,,7,12611,359,5
  • Changes to framework-coverage-csharp.csv:
- package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:local,summary:taint,summary:value
+ package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:local,source:remote,summary:taint,summary:value
- Dapper,55,,,,,,55,,,,
+ Dapper,55,,,,,,55,,,,,
- JsonToItemsTaskFactory,,,7,,,,,,,7,
+ JsonToItemsTaskFactory,,,7,,,,,,,,7,
- Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,,,
- Microsoft.CSharp,,,24,,,,,,,24,
+ Microsoft.CSharp,,,24,,,,,,,,24,
- Microsoft.EntityFrameworkCore,6,,,,,,6,,,,
+ Microsoft.EntityFrameworkCore,6,,,,,,6,,,,,
- Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,15,
+ Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,15,
- Microsoft.Extensions.Caching.Memory,,,46,,,,,,,45,1
+ Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,45,1
- Microsoft.Extensions.Configuration,,,83,,,,,,,80,3
+ Microsoft.Extensions.Configuration,,,83,,,,,,,,80,3
- Microsoft.Extensions.DependencyInjection,,,62,,,,,,,62,
+ Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,62,
- Microsoft.Extensions.DependencyModel,,,12,,,,,,,12,
+ Microsoft.Extensions.DependencyModel,,,12,,,,,,,,12,
- Microsoft.Extensions.FileProviders,,,15,,,,,,,15,
+ Microsoft.Extensions.FileProviders,,,15,,,,,,,,15,
- Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,13,2
+ Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,13,2
- Microsoft.Extensions.Hosting,,,17,,,,,,,16,1
+ Microsoft.Extensions.Hosting,,,17,,,,,,,,16,1
- Microsoft.Extensions.Http,,,10,,,,,,,10,
+ Microsoft.Extensions.Http,,,10,,,,,,,,10,
- Microsoft.Extensions.Logging,,,37,,,,,,,37,
+ Microsoft.Extensions.Logging,,,37,,,,,,,,37,
- Microsoft.Extensions.Options,,,8,,,,,,,8,
+ Microsoft.Extensions.Options,,,8,,,,,,,,8,
- Microsoft.Extensions.Primitives,,,63,,,,,,,63,
+ Microsoft.Extensions.Primitives,,,63,,,,,,,,63,
- Microsoft.Interop,,,27,,,,,,,27,
+ Microsoft.Interop,,,27,,,,,,,,27,
- Microsoft.NET.Build.Tasks,,,1,,,,,,,1,
+ Microsoft.NET.Build.Tasks,,,1,,,,,,,,1,
- Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,4,
+ Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,4,
- Microsoft.VisualBasic,,,9,,,,,,,5,4
+ Microsoft.VisualBasic,,,9,,,,,,,,5,4
- Microsoft.Win32,,,8,,,,,,,8,
+ Microsoft.Win32,,,8,,,,,,,,8,
- MySql.Data.MySqlClient,48,,,,,,48,,,,
+ MySql.Data.MySqlClient,48,,,,,,48,,,,,
- Newtonsoft.Json,,,91,,,,,,,73,18
+ Newtonsoft.Json,,,91,,,,,,,,73,18
- ServiceStack,194,,7,27,,75,92,,,7,
+ ServiceStack,194,,7,27,,75,92,,,,7,
- System,28,3,12038,,4,,23,1,3,10096,1942
+ System,28,7,12050,,4,,23,1,3,4,10108,1942

github-actions[bot] avatar Jun 02 '22 11:06 github-actions[bot]

Question, since GetStream is a source of taint by itself are any changes to "System.Net.Sockets;TcpClient;false;GetStream;();;Argument[Qualifier];ReturnValue;generated:taint", in runtime.qll needed?

I don't think so. Maybe also create small testcase for this to make sure that source models and taint steps are applied correctly during taint tracking.

michaelnebel avatar Jun 02 '22 12:06 michaelnebel

The new models looks plausible to me. Unit test failures needs to be inspected.

michaelnebel avatar Jun 02 '22 12:06 michaelnebel

:warning: The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",3,12038,28,5
+    System,"``System.*``, ``System``",3,12050,28,5
-    Totals,,3,12599,359,5
+    Totals,,3,12611,359,5
  • Changes to framework-coverage-csharp.csv:
- System,28,3,12038,,4,,23,1,3,10096,1942
+ System,28,3,12050,,4,,23,1,3,10108,1942

github-actions[bot] avatar Jul 13 '22 20:07 github-actions[bot]

Since I have added only source and summary it is quite different form the usual add new query test. There are no tests for Compression.qll for an instance. I'm looking for an example of source and summary tests I could add. Do you have and idea?

JarLob avatar Jul 13 '22 20:07 JarLob

Since I have added only source and summary it is quite different form the usual add new query test. There are no tests for Compression.qll for an instance. I'm looking for an example of source and summary tests I could add. Do you have and idea?

If there doesn't already exist a test then maybe it is fine to run the query against a database with a known vulnerability that should now be discovered by the addition of these models (@hvitved : Or is there another policy on what to do?).

The existing failing unit tests should be updated to reflect the new model changes (let me know, if you need any help with that.)

michaelnebel avatar Jul 22 '22 13:07 michaelnebel

:warning: The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",4,11809,43,7
+    System,"``System.*``, ``System``",4,11821,43,7
-    Totals,,4,12370,375,7
+    Totals,,4,12382,375,7
  • Changes to framework-coverage-csharp.csv:
- System,43,4,11809,,1,1,1,,4,,33,3,1,3,9867,1942
+ System,43,4,11821,,1,1,1,,4,,33,3,1,3,9879,1942

github-actions[bot] avatar Aug 24 '22 09:08 github-actions[bot]

:warning: The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",4,11809,43,7
+    System,"``System.*``, ``System``",4,11821,43,7
-    Totals,,4,12370,375,7
+    Totals,,4,12382,375,7
  • Changes to framework-coverage-csharp.csv:
- System,43,4,11809,,1,1,1,,4,,33,3,1,3,9867,1942
+ System,43,4,11821,,1,1,1,,4,,33,3,1,3,9879,1942

github-actions[bot] avatar Aug 24 '22 09:08 github-actions[bot]

:warning: The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",4,12131,65,7
+    System,"``System.*``, ``System``",4,12143,65,7
-    Totals,,4,12694,397,7
+    Totals,,4,12706,397,7
  • Changes to framework-coverage-csharp.csv:
- System,65,4,12131,,8,8,9,,4,,33,3,1,3,10139,1992
+ System,65,4,12143,,8,8,9,,4,,33,3,1,3,10151,1992

github-actions[bot] avatar Nov 01 '22 18:11 github-actions[bot]

:warning: The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",4,12131,65,7
+    System,"``System.*``, ``System``",4,12143,65,7
-    Totals,,4,12694,397,7
+    Totals,,4,12706,397,7
  • Changes to framework-coverage-csharp.csv:
- System,65,4,12131,,8,8,9,,4,,33,3,1,3,10139,1992
+ System,65,4,12143,,8,8,9,,4,,33,3,1,3,10151,1992

github-actions[bot] avatar Nov 01 '22 18:11 github-actions[bot]

:warning: The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",4,12131,65,7
+    System,"``System.*``, ``System``",4,12143,65,7
-    Totals,,4,12694,397,7
+    Totals,,4,12706,397,7
  • Changes to framework-coverage-csharp.csv:
- System,65,4,12131,,8,8,9,,4,,33,3,1,3,10139,1992
+ System,65,4,12143,,8,8,9,,4,,33,3,1,3,10151,1992

github-actions[bot] avatar Nov 01 '22 18:11 github-actions[bot]

:warning: The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",4,12131,65,7
+    System,"``System.*``, ``System``",8,12143,65,7
-    Totals,,4,12694,397,7
+    Totals,,8,12706,397,7
  • Changes to framework-coverage-csharp.csv:
- package,sink,source,summary,sink:code,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,summary:taint,summary:value
+ package,sink,source,summary,sink:code,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,source:remote,summary:taint,summary:value
- Dapper,55,,,,,,,,,,55,,,,,
+ Dapper,55,,,,,,,,,,55,,,,,,
- JsonToItemsTaskFactory,,,7,,,,,,,,,,,,7,
+ JsonToItemsTaskFactory,,,7,,,,,,,,,,,,,7,
- Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,28,,,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,28,,,,,,
- Microsoft.CSharp,,,24,,,,,,,,,,,,24,
+ Microsoft.CSharp,,,24,,,,,,,,,,,,,24,
- Microsoft.EntityFrameworkCore,6,,,,,,,,,,6,,,,,
+ Microsoft.EntityFrameworkCore,6,,,,,,,,,,6,,,,,,
- Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,,,,,15,
+ Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,,,,,,15,
- Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,,,,,45,1
+ Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,,,,,,45,1
- Microsoft.Extensions.Configuration,,,83,,,,,,,,,,,,80,3
+ Microsoft.Extensions.Configuration,,,83,,,,,,,,,,,,,80,3
- Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,,,,,62,
+ Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,,,,,,62,
- Microsoft.Extensions.DependencyModel,,,12,,,,,,,,,,,,12,
+ Microsoft.Extensions.DependencyModel,,,12,,,,,,,,,,,,,12,
- Microsoft.Extensions.FileProviders,,,16,,,,,,,,,,,,16,
+ Microsoft.Extensions.FileProviders,,,16,,,,,,,,,,,,,16,
- Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,,,,,13,2
+ Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,,,,,,13,2
- Microsoft.Extensions.Hosting,,,17,,,,,,,,,,,,16,1
+ Microsoft.Extensions.Hosting,,,17,,,,,,,,,,,,,16,1
- Microsoft.Extensions.Http,,,10,,,,,,,,,,,,10,
+ Microsoft.Extensions.Http,,,10,,,,,,,,,,,,,10,
- Microsoft.Extensions.Logging,,,37,,,,,,,,,,,,37,
+ Microsoft.Extensions.Logging,,,37,,,,,,,,,,,,,37,
- Microsoft.Extensions.Options,,,8,,,,,,,,,,,,8,
+ Microsoft.Extensions.Options,,,8,,,,,,,,,,,,,8,
- Microsoft.Extensions.Primitives,,,63,,,,,,,,,,,,63,
+ Microsoft.Extensions.Primitives,,,63,,,,,,,,,,,,,63,
- Microsoft.Interop,,,27,,,,,,,,,,,,27,
+ Microsoft.Interop,,,27,,,,,,,,,,,,,27,
- Microsoft.NET.Build.Tasks,,,1,,,,,,,,,,,,1,
+ Microsoft.NET.Build.Tasks,,,1,,,,,,,,,,,,,1,
- Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,,,,,4,
+ Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,,,,,,4,
- Microsoft.VisualBasic,,,10,,,,,,,,,,,,5,5
+ Microsoft.VisualBasic,,,10,,,,,,,,,,,,,5,5
- Microsoft.Win32,,,8,,,,,,,,,,,,8,
+ Microsoft.Win32,,,8,,,,,,,,,,,,,8,
- MySql.Data.MySqlClient,48,,,,,,,,,,48,,,,,
+ MySql.Data.MySqlClient,48,,,,,,,,,,48,,,,,,
- Newtonsoft.Json,,,91,,,,,,,,,,,,73,18
+ Newtonsoft.Json,,,91,,,,,,,,,,,,,73,18
- ServiceStack,194,,7,27,,,,,,75,92,,,,7,
+ ServiceStack,194,,7,27,,,,,,75,92,,,,,7,
- System,65,4,12131,,8,8,9,,4,,33,3,1,3,10139,1992
+ System,65,8,12143,,8,8,9,,4,,33,3,1,3,4,10151,1992
- Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,,
+ Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,,,

github-actions[bot] avatar Nov 01 '22 21:11 github-actions[bot]

@michaelnebel I was getting Wrong number of columns in source model row, expected 9, got 8 in System.Net.Sockets;TcpClient;false;GetStream;;;ReturnValue;remote. | so I have added ;manual in attempt to fix that, now it still complains | Invalid kind "remote" in source model. |. Any advise what is wrong?

JarLob avatar Nov 01 '22 23:11 JarLob

@michaelnebel I was getting Wrong number of columns in source model row, expected 9, got 8 in System.Net.Sockets;TcpClient;false;GetStream;;;ReturnValue;remote. | so I have added ;manual in attempt to fix that, now it still complains | Invalid kind "remote" in source model. |. Any advise what is wrong?

Yes, there is a validation of the allowed kinds used in all types of models. The only allowed kinds for source models are local and file, but you are welcome to introduce a new kind for source models. If you want to allow new source kinds, you need to change the validation here: https://github.com/github/codeql/blob/28b7ab7fbeab2a5852b0743b180302956c47a6f9/csharp/ql/lib/semmle/code/csharp/dataflow/ExternalFlow.qll#L373

michaelnebel avatar Nov 02 '22 07:11 michaelnebel

:warning: The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",4,12131,65,7
+    System,"``System.*``, ``System``",8,12143,65,7
-    Totals,,4,12694,397,7
+    Totals,,8,12706,397,7
  • Changes to framework-coverage-csharp.csv:
- package,sink,source,summary,sink:code,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,summary:taint,summary:value
+ package,sink,source,summary,sink:code,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,source:remote,summary:taint,summary:value
- Dapper,55,,,,,,,,,,55,,,,,
+ Dapper,55,,,,,,,,,,55,,,,,,
- JsonToItemsTaskFactory,,,7,,,,,,,,,,,,7,
+ JsonToItemsTaskFactory,,,7,,,,,,,,,,,,,7,
- Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,28,,,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,28,,,,,,
- Microsoft.CSharp,,,24,,,,,,,,,,,,24,
+ Microsoft.CSharp,,,24,,,,,,,,,,,,,24,
- Microsoft.EntityFrameworkCore,6,,,,,,,,,,6,,,,,
+ Microsoft.EntityFrameworkCore,6,,,,,,,,,,6,,,,,,
- Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,,,,,15,
+ Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,,,,,,15,
- Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,,,,,45,1
+ Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,,,,,,45,1
- Microsoft.Extensions.Configuration,,,83,,,,,,,,,,,,80,3
+ Microsoft.Extensions.Configuration,,,83,,,,,,,,,,,,,80,3
- Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,,,,,62,
+ Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,,,,,,62,
- Microsoft.Extensions.DependencyModel,,,12,,,,,,,,,,,,12,
+ Microsoft.Extensions.DependencyModel,,,12,,,,,,,,,,,,,12,
- Microsoft.Extensions.FileProviders,,,16,,,,,,,,,,,,16,
+ Microsoft.Extensions.FileProviders,,,16,,,,,,,,,,,,,16,
- Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,,,,,13,2
+ Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,,,,,,13,2
- Microsoft.Extensions.Hosting,,,17,,,,,,,,,,,,16,1
+ Microsoft.Extensions.Hosting,,,17,,,,,,,,,,,,,16,1
- Microsoft.Extensions.Http,,,10,,,,,,,,,,,,10,
+ Microsoft.Extensions.Http,,,10,,,,,,,,,,,,,10,
- Microsoft.Extensions.Logging,,,37,,,,,,,,,,,,37,
+ Microsoft.Extensions.Logging,,,37,,,,,,,,,,,,,37,
- Microsoft.Extensions.Options,,,8,,,,,,,,,,,,8,
+ Microsoft.Extensions.Options,,,8,,,,,,,,,,,,,8,
- Microsoft.Extensions.Primitives,,,63,,,,,,,,,,,,63,
+ Microsoft.Extensions.Primitives,,,63,,,,,,,,,,,,,63,
- Microsoft.Interop,,,27,,,,,,,,,,,,27,
+ Microsoft.Interop,,,27,,,,,,,,,,,,,27,
- Microsoft.NET.Build.Tasks,,,1,,,,,,,,,,,,1,
+ Microsoft.NET.Build.Tasks,,,1,,,,,,,,,,,,,1,
- Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,,,,,4,
+ Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,,,,,,4,
- Microsoft.VisualBasic,,,10,,,,,,,,,,,,5,5
+ Microsoft.VisualBasic,,,10,,,,,,,,,,,,,5,5
- Microsoft.Win32,,,8,,,,,,,,,,,,8,
+ Microsoft.Win32,,,8,,,,,,,,,,,,,8,
- MySql.Data.MySqlClient,48,,,,,,,,,,48,,,,,
+ MySql.Data.MySqlClient,48,,,,,,,,,,48,,,,,,
- Newtonsoft.Json,,,91,,,,,,,,,,,,73,18
+ Newtonsoft.Json,,,91,,,,,,,,,,,,,73,18
- ServiceStack,194,,7,27,,,,,,75,92,,,,7,
+ ServiceStack,194,,7,27,,,,,,75,92,,,,,7,
- System,65,4,12131,,8,8,9,,4,,33,3,1,3,10139,1992
+ System,65,8,12143,,8,8,9,,4,,33,3,1,3,4,10151,1992
- Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,,
+ Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,,,

github-actions[bot] avatar Nov 02 '22 08:11 github-actions[bot]

:warning: The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",4,12131,65,7
+    System,"``System.*``, ``System``",8,12143,65,7
-    Totals,,4,12694,397,7
+    Totals,,8,12706,397,7
  • Changes to framework-coverage-csharp.csv:
- package,sink,source,summary,sink:code,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,summary:taint,summary:value
+ package,sink,source,summary,sink:code,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,source:remote,summary:taint,summary:value
- Dapper,55,,,,,,,,,,55,,,,,
+ Dapper,55,,,,,,,,,,55,,,,,,
- JsonToItemsTaskFactory,,,7,,,,,,,,,,,,7,
+ JsonToItemsTaskFactory,,,7,,,,,,,,,,,,,7,
- Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,28,,,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,28,,,,,,
- Microsoft.CSharp,,,24,,,,,,,,,,,,24,
+ Microsoft.CSharp,,,24,,,,,,,,,,,,,24,
- Microsoft.EntityFrameworkCore,6,,,,,,,,,,6,,,,,
+ Microsoft.EntityFrameworkCore,6,,,,,,,,,,6,,,,,,
- Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,,,,,15,
+ Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,,,,,,15,
- Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,,,,,45,1
+ Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,,,,,,45,1
- Microsoft.Extensions.Configuration,,,83,,,,,,,,,,,,80,3
+ Microsoft.Extensions.Configuration,,,83,,,,,,,,,,,,,80,3
- Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,,,,,62,
+ Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,,,,,,62,
- Microsoft.Extensions.DependencyModel,,,12,,,,,,,,,,,,12,
+ Microsoft.Extensions.DependencyModel,,,12,,,,,,,,,,,,,12,
- Microsoft.Extensions.FileProviders,,,16,,,,,,,,,,,,16,
+ Microsoft.Extensions.FileProviders,,,16,,,,,,,,,,,,,16,
- Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,,,,,13,2
+ Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,,,,,,13,2
- Microsoft.Extensions.Hosting,,,17,,,,,,,,,,,,16,1
+ Microsoft.Extensions.Hosting,,,17,,,,,,,,,,,,,16,1
- Microsoft.Extensions.Http,,,10,,,,,,,,,,,,10,
+ Microsoft.Extensions.Http,,,10,,,,,,,,,,,,,10,
- Microsoft.Extensions.Logging,,,37,,,,,,,,,,,,37,
+ Microsoft.Extensions.Logging,,,37,,,,,,,,,,,,,37,
- Microsoft.Extensions.Options,,,8,,,,,,,,,,,,8,
+ Microsoft.Extensions.Options,,,8,,,,,,,,,,,,,8,
- Microsoft.Extensions.Primitives,,,63,,,,,,,,,,,,63,
+ Microsoft.Extensions.Primitives,,,63,,,,,,,,,,,,,63,
- Microsoft.Interop,,,27,,,,,,,,,,,,27,
+ Microsoft.Interop,,,27,,,,,,,,,,,,,27,
- Microsoft.NET.Build.Tasks,,,1,,,,,,,,,,,,1,
+ Microsoft.NET.Build.Tasks,,,1,,,,,,,,,,,,,1,
- Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,,,,,4,
+ Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,,,,,,4,
- Microsoft.VisualBasic,,,10,,,,,,,,,,,,5,5
+ Microsoft.VisualBasic,,,10,,,,,,,,,,,,,5,5
- Microsoft.Win32,,,8,,,,,,,,,,,,8,
+ Microsoft.Win32,,,8,,,,,,,,,,,,,8,
- MySql.Data.MySqlClient,48,,,,,,,,,,48,,,,,
+ MySql.Data.MySqlClient,48,,,,,,,,,,48,,,,,,
- Newtonsoft.Json,,,91,,,,,,,,,,,,73,18
+ Newtonsoft.Json,,,91,,,,,,,,,,,,,73,18
- ServiceStack,194,,7,27,,,,,,75,92,,,,7,
+ ServiceStack,194,,7,27,,,,,,75,92,,,,,7,
- System,65,4,12131,,8,8,9,,4,,33,3,1,3,10139,1992
+ System,65,8,12143,,8,8,9,,4,,33,3,1,3,4,10151,1992
- Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,,
+ Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,,,

github-actions[bot] avatar Nov 02 '22 10:11 github-actions[bot]

Finally, everything is green.

JarLob avatar Nov 02 '22 11:11 JarLob

Finally, everything is green.

I'll start a performance/results comparison job.

hvitved avatar Nov 02 '22 12:11 hvitved

:warning: The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",4,12142,65,7
+    System,"``System.*``, ``System``",8,12142,65,7
-    Totals,,4,12705,397,7
+    Totals,,8,12705,397,7
  • Changes to framework-coverage-csharp.csv:
- package,sink,source,summary,sink:code,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,summary:taint,summary:value
+ package,sink,source,summary,sink:code,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,source:remote,summary:taint,summary:value
- Dapper,55,,,,,,,,,,55,,,,,
+ Dapper,55,,,,,,,,,,55,,,,,,
- JsonToItemsTaskFactory,,,7,,,,,,,,,,,,7,
+ JsonToItemsTaskFactory,,,7,,,,,,,,,,,,,7,
- Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,28,,,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,28,,,,,,
- Microsoft.CSharp,,,24,,,,,,,,,,,,24,
+ Microsoft.CSharp,,,24,,,,,,,,,,,,,24,
- Microsoft.EntityFrameworkCore,6,,,,,,,,,,6,,,,,
+ Microsoft.EntityFrameworkCore,6,,,,,,,,,,6,,,,,,
- Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,,,,,15,
+ Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,,,,,,15,
- Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,,,,,45,1
+ Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,,,,,,45,1
- Microsoft.Extensions.Configuration,,,83,,,,,,,,,,,,80,3
+ Microsoft.Extensions.Configuration,,,83,,,,,,,,,,,,,80,3
- Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,,,,,62,
+ Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,,,,,,62,
- Microsoft.Extensions.DependencyModel,,,12,,,,,,,,,,,,12,
+ Microsoft.Extensions.DependencyModel,,,12,,,,,,,,,,,,,12,
- Microsoft.Extensions.FileProviders,,,16,,,,,,,,,,,,16,
+ Microsoft.Extensions.FileProviders,,,16,,,,,,,,,,,,,16,
- Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,,,,,13,2
+ Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,,,,,,13,2
- Microsoft.Extensions.Hosting,,,17,,,,,,,,,,,,16,1
+ Microsoft.Extensions.Hosting,,,17,,,,,,,,,,,,,16,1
- Microsoft.Extensions.Http,,,10,,,,,,,,,,,,10,
+ Microsoft.Extensions.Http,,,10,,,,,,,,,,,,,10,
- Microsoft.Extensions.Logging,,,37,,,,,,,,,,,,37,
+ Microsoft.Extensions.Logging,,,37,,,,,,,,,,,,,37,
- Microsoft.Extensions.Options,,,8,,,,,,,,,,,,8,
+ Microsoft.Extensions.Options,,,8,,,,,,,,,,,,,8,
- Microsoft.Extensions.Primitives,,,63,,,,,,,,,,,,63,
+ Microsoft.Extensions.Primitives,,,63,,,,,,,,,,,,,63,
- Microsoft.Interop,,,27,,,,,,,,,,,,27,
+ Microsoft.Interop,,,27,,,,,,,,,,,,,27,
- Microsoft.NET.Build.Tasks,,,1,,,,,,,,,,,,1,
+ Microsoft.NET.Build.Tasks,,,1,,,,,,,,,,,,,1,
- Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,,,,,4,
+ Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,,,,,,4,
- Microsoft.VisualBasic,,,10,,,,,,,,,,,,5,5
+ Microsoft.VisualBasic,,,10,,,,,,,,,,,,,5,5
- Microsoft.Win32,,,8,,,,,,,,,,,,8,
+ Microsoft.Win32,,,8,,,,,,,,,,,,,8,
- MySql.Data.MySqlClient,48,,,,,,,,,,48,,,,,
+ MySql.Data.MySqlClient,48,,,,,,,,,,48,,,,,,
- Newtonsoft.Json,,,91,,,,,,,,,,,,73,18
+ Newtonsoft.Json,,,91,,,,,,,,,,,,,73,18
- ServiceStack,194,,7,27,,,,,,75,92,,,,7,
+ ServiceStack,194,,7,27,,,,,,75,92,,,,,7,
- System,65,4,12142,,8,8,9,,4,,33,3,1,3,10151,1991
+ System,65,8,12142,,8,8,9,,4,,33,3,1,3,4,10151,1991
- Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,,
+ Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,,,

github-actions[bot] avatar Nov 29 '22 13:11 github-actions[bot]

New merge conflicts appeared. I have revolved that. However I'm not sure about https://github.com/github/codeql/pull/9415/commits/6462423b7e91ff90a98567fef7e9efdb69f1dd31#diff-0bf160019833ad6f9c40ea33257e19a1945f2287468b4871f1064f2d0bc58ec1R114 I see that the imports were deleted in https://github.com/github/codeql/commit/582cfb93304783fa472e69cd56cf420ec1e50bc3 by @michaelnebel Hopefully it still works without the StreamReader import. Can we get it merged now if tests pass?

JarLob avatar Nov 29 '22 13:11 JarLob

It fails... @michaelnebel could you please suggest what is wrong?

JarLob avatar Nov 29 '22 13:11 JarLob

It fails... @michaelnebel could you please suggest what is wrong?

Yes, we have migrated all models as data models to be defined in data extensions instead of inlined in the code. That is, they need to written in YAML format instead and put in the lib/ext folder. There is a a file pr. namespace (named <namespace>.model.yml.

michaelnebel avatar Nov 30 '22 10:11 michaelnebel

:warning: The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",4,12142,65,7
+    System,"``System.*``, ``System``",8,12142,65,7
-    Totals,,4,12705,397,7
+    Totals,,8,12705,397,7
  • Changes to framework-coverage-csharp.csv:
- package,sink,source,summary,sink:code,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,summary:taint,summary:value
+ package,sink,source,summary,sink:code,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,source:remote,summary:taint,summary:value
- Dapper,55,,,,,,,,,,55,,,,,
+ Dapper,55,,,,,,,,,,55,,,,,,
- JsonToItemsTaskFactory,,,7,,,,,,,,,,,,7,
+ JsonToItemsTaskFactory,,,7,,,,,,,,,,,,,7,
- Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,28,,,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,28,,,,,,
- Microsoft.CSharp,,,24,,,,,,,,,,,,24,
+ Microsoft.CSharp,,,24,,,,,,,,,,,,,24,
- Microsoft.EntityFrameworkCore,6,,,,,,,,,,6,,,,,
+ Microsoft.EntityFrameworkCore,6,,,,,,,,,,6,,,,,,
- Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,,,,,15,
+ Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,,,,,,15,
- Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,,,,,45,1
+ Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,,,,,,45,1
- Microsoft.Extensions.Configuration,,,83,,,,,,,,,,,,80,3
+ Microsoft.Extensions.Configuration,,,83,,,,,,,,,,,,,80,3
- Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,,,,,62,
+ Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,,,,,,62,
- Microsoft.Extensions.DependencyModel,,,12,,,,,,,,,,,,12,
+ Microsoft.Extensions.DependencyModel,,,12,,,,,,,,,,,,,12,
- Microsoft.Extensions.FileProviders,,,16,,,,,,,,,,,,16,
+ Microsoft.Extensions.FileProviders,,,16,,,,,,,,,,,,,16,
- Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,,,,,13,2
+ Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,,,,,,13,2
- Microsoft.Extensions.Hosting,,,17,,,,,,,,,,,,16,1
+ Microsoft.Extensions.Hosting,,,17,,,,,,,,,,,,,16,1
- Microsoft.Extensions.Http,,,10,,,,,,,,,,,,10,
+ Microsoft.Extensions.Http,,,10,,,,,,,,,,,,,10,
- Microsoft.Extensions.Logging,,,37,,,,,,,,,,,,37,
+ Microsoft.Extensions.Logging,,,37,,,,,,,,,,,,,37,
- Microsoft.Extensions.Options,,,8,,,,,,,,,,,,8,
+ Microsoft.Extensions.Options,,,8,,,,,,,,,,,,,8,
- Microsoft.Extensions.Primitives,,,63,,,,,,,,,,,,63,
+ Microsoft.Extensions.Primitives,,,63,,,,,,,,,,,,,63,
- Microsoft.Interop,,,27,,,,,,,,,,,,27,
+ Microsoft.Interop,,,27,,,,,,,,,,,,,27,
- Microsoft.NET.Build.Tasks,,,1,,,,,,,,,,,,1,
+ Microsoft.NET.Build.Tasks,,,1,,,,,,,,,,,,,1,
- Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,,,,,4,
+ Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,,,,,,4,
- Microsoft.VisualBasic,,,10,,,,,,,,,,,,5,5
+ Microsoft.VisualBasic,,,10,,,,,,,,,,,,,5,5
- Microsoft.Win32,,,8,,,,,,,,,,,,8,
+ Microsoft.Win32,,,8,,,,,,,,,,,,,8,
- MySql.Data.MySqlClient,48,,,,,,,,,,48,,,,,
+ MySql.Data.MySqlClient,48,,,,,,,,,,48,,,,,,
- Newtonsoft.Json,,,91,,,,,,,,,,,,73,18
+ Newtonsoft.Json,,,91,,,,,,,,,,,,,73,18
- ServiceStack,194,,7,27,,,,,,75,92,,,,7,
+ ServiceStack,194,,7,27,,,,,,75,92,,,,,7,
- System,65,4,12142,,8,8,9,,4,,33,3,1,3,10151,1991
+ System,65,8,12142,,8,8,9,,4,,33,3,1,3,4,10151,1991
- Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,,
+ Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,,,

github-actions[bot] avatar Nov 30 '22 10:11 github-actions[bot]

:warning: The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",4,12142,65,7
+    System,"``System.*``, ``System``",8,12154,65,7
-    Totals,,4,12705,397,7
+    Totals,,8,12717,397,7
  • Changes to framework-coverage-csharp.csv:
- package,sink,source,summary,sink:code,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,summary:taint,summary:value
+ package,sink,source,summary,sink:code,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,source:remote,summary:taint,summary:value
- Dapper,55,,,,,,,,,,55,,,,,
+ Dapper,55,,,,,,,,,,55,,,,,,
- JsonToItemsTaskFactory,,,7,,,,,,,,,,,,7,
+ JsonToItemsTaskFactory,,,7,,,,,,,,,,,,,7,
- Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,28,,,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,28,,,,,,
- Microsoft.CSharp,,,24,,,,,,,,,,,,24,
+ Microsoft.CSharp,,,24,,,,,,,,,,,,,24,
- Microsoft.EntityFrameworkCore,6,,,,,,,,,,6,,,,,
+ Microsoft.EntityFrameworkCore,6,,,,,,,,,,6,,,,,,
- Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,,,,,15,
+ Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,,,,,,15,
- Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,,,,,45,1
+ Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,,,,,,45,1
- Microsoft.Extensions.Configuration,,,83,,,,,,,,,,,,80,3
+ Microsoft.Extensions.Configuration,,,83,,,,,,,,,,,,,80,3
- Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,,,,,62,
+ Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,,,,,,62,
- Microsoft.Extensions.DependencyModel,,,12,,,,,,,,,,,,12,
+ Microsoft.Extensions.DependencyModel,,,12,,,,,,,,,,,,,12,
- Microsoft.Extensions.FileProviders,,,16,,,,,,,,,,,,16,
+ Microsoft.Extensions.FileProviders,,,16,,,,,,,,,,,,,16,
- Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,,,,,13,2
+ Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,,,,,,13,2
- Microsoft.Extensions.Hosting,,,17,,,,,,,,,,,,16,1
+ Microsoft.Extensions.Hosting,,,17,,,,,,,,,,,,,16,1
- Microsoft.Extensions.Http,,,10,,,,,,,,,,,,10,
+ Microsoft.Extensions.Http,,,10,,,,,,,,,,,,,10,
- Microsoft.Extensions.Logging,,,37,,,,,,,,,,,,37,
+ Microsoft.Extensions.Logging,,,37,,,,,,,,,,,,,37,
- Microsoft.Extensions.Options,,,8,,,,,,,,,,,,8,
+ Microsoft.Extensions.Options,,,8,,,,,,,,,,,,,8,
- Microsoft.Extensions.Primitives,,,63,,,,,,,,,,,,63,
+ Microsoft.Extensions.Primitives,,,63,,,,,,,,,,,,,63,
- Microsoft.Interop,,,27,,,,,,,,,,,,27,
+ Microsoft.Interop,,,27,,,,,,,,,,,,,27,
- Microsoft.NET.Build.Tasks,,,1,,,,,,,,,,,,1,
+ Microsoft.NET.Build.Tasks,,,1,,,,,,,,,,,,,1,
- Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,,,,,4,
+ Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,,,,,,4,
- Microsoft.VisualBasic,,,10,,,,,,,,,,,,5,5
+ Microsoft.VisualBasic,,,10,,,,,,,,,,,,,5,5
- Microsoft.Win32,,,8,,,,,,,,,,,,8,
+ Microsoft.Win32,,,8,,,,,,,,,,,,,8,
- MySql.Data.MySqlClient,48,,,,,,,,,,48,,,,,
+ MySql.Data.MySqlClient,48,,,,,,,,,,48,,,,,,
- Newtonsoft.Json,,,91,,,,,,,,,,,,73,18
+ Newtonsoft.Json,,,91,,,,,,,,,,,,,73,18
- ServiceStack,194,,7,27,,,,,,75,92,,,,7,
+ ServiceStack,194,,7,27,,,,,,75,92,,,,,7,
- System,65,4,12142,,8,8,9,,4,,33,3,1,3,10151,1991
+ System,65,8,12154,,8,8,9,,4,,33,3,1,3,4,10163,1991
- Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,,
+ Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,,,

github-actions[bot] avatar Nov 30 '22 11:11 github-actions[bot]

:warning: The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",4,12142,65,7
+    System,"``System.*``, ``System``",8,12154,65,7
-    Totals,,4,12705,397,7
+    Totals,,8,12717,397,7
  • Changes to framework-coverage-csharp.csv:
- package,sink,source,summary,sink:code,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,summary:taint,summary:value
+ package,sink,source,summary,sink:code,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,source:remote,summary:taint,summary:value
- Dapper,55,,,,,,,,,,55,,,,,
+ Dapper,55,,,,,,,,,,55,,,,,,
- JsonToItemsTaskFactory,,,7,,,,,,,,,,,,7,
+ JsonToItemsTaskFactory,,,7,,,,,,,,,,,,,7,
- Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,28,,,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,28,,,,,,
- Microsoft.CSharp,,,24,,,,,,,,,,,,24,
+ Microsoft.CSharp,,,24,,,,,,,,,,,,,24,
- Microsoft.EntityFrameworkCore,6,,,,,,,,,,6,,,,,
+ Microsoft.EntityFrameworkCore,6,,,,,,,,,,6,,,,,,
- Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,,,,,15,
+ Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,,,,,,15,
- Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,,,,,45,1
+ Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,,,,,,45,1
- Microsoft.Extensions.Configuration,,,83,,,,,,,,,,,,80,3
+ Microsoft.Extensions.Configuration,,,83,,,,,,,,,,,,,80,3
- Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,,,,,62,
+ Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,,,,,,62,
- Microsoft.Extensions.DependencyModel,,,12,,,,,,,,,,,,12,
+ Microsoft.Extensions.DependencyModel,,,12,,,,,,,,,,,,,12,
- Microsoft.Extensions.FileProviders,,,16,,,,,,,,,,,,16,
+ Microsoft.Extensions.FileProviders,,,16,,,,,,,,,,,,,16,
- Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,,,,,13,2
+ Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,,,,,,13,2
- Microsoft.Extensions.Hosting,,,17,,,,,,,,,,,,16,1
+ Microsoft.Extensions.Hosting,,,17,,,,,,,,,,,,,16,1
- Microsoft.Extensions.Http,,,10,,,,,,,,,,,,10,
+ Microsoft.Extensions.Http,,,10,,,,,,,,,,,,,10,
- Microsoft.Extensions.Logging,,,37,,,,,,,,,,,,37,
+ Microsoft.Extensions.Logging,,,37,,,,,,,,,,,,,37,
- Microsoft.Extensions.Options,,,8,,,,,,,,,,,,8,
+ Microsoft.Extensions.Options,,,8,,,,,,,,,,,,,8,
- Microsoft.Extensions.Primitives,,,63,,,,,,,,,,,,63,
+ Microsoft.Extensions.Primitives,,,63,,,,,,,,,,,,,63,
- Microsoft.Interop,,,27,,,,,,,,,,,,27,
+ Microsoft.Interop,,,27,,,,,,,,,,,,,27,
- Microsoft.NET.Build.Tasks,,,1,,,,,,,,,,,,1,
+ Microsoft.NET.Build.Tasks,,,1,,,,,,,,,,,,,1,
- Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,,,,,4,
+ Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,,,,,,4,
- Microsoft.VisualBasic,,,10,,,,,,,,,,,,5,5
+ Microsoft.VisualBasic,,,10,,,,,,,,,,,,,5,5
- Microsoft.Win32,,,8,,,,,,,,,,,,8,
+ Microsoft.Win32,,,8,,,,,,,,,,,,,8,
- MySql.Data.MySqlClient,48,,,,,,,,,,48,,,,,
+ MySql.Data.MySqlClient,48,,,,,,,,,,48,,,,,,
- Newtonsoft.Json,,,91,,,,,,,,,,,,73,18
+ Newtonsoft.Json,,,91,,,,,,,,,,,,,73,18
- ServiceStack,194,,7,27,,,,,,75,92,,,,7,
+ ServiceStack,194,,7,27,,,,,,75,92,,,,,7,
- System,65,4,12142,,8,8,9,,4,,33,3,1,3,10151,1991
+ System,65,8,12154,,8,8,9,,4,,33,3,1,3,4,10163,1991
- Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,,
+ Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,,,

github-actions[bot] avatar Nov 30 '22 12:11 github-actions[bot]

All checks pass. Please review and merge as soon as it looks good. From the other pull request it seems there was a misunderstanding who should merge the PR as long as it is approved.

JarLob avatar Nov 30 '22 12:11 JarLob

:warning: The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",4,12142,65,7
+    System,"``System.*``, ``System``",8,12154,65,7
-    Totals,,4,12705,397,7
+    Totals,,8,12717,397,7
  • Changes to framework-coverage-csharp.csv:
- package,sink,source,summary,sink:code,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,summary:taint,summary:value
+ package,sink,source,summary,sink:code,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,source:remote,summary:taint,summary:value
- Dapper,55,,,,,,,,,,55,,,,,
+ Dapper,55,,,,,,,,,,55,,,,,,
- JsonToItemsTaskFactory,,,7,,,,,,,,,,,,7,
+ JsonToItemsTaskFactory,,,7,,,,,,,,,,,,,7,
- Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,28,,,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,28,,,,,,
- Microsoft.CSharp,,,24,,,,,,,,,,,,24,
+ Microsoft.CSharp,,,24,,,,,,,,,,,,,24,
- Microsoft.EntityFrameworkCore,6,,,,,,,,,,6,,,,,
+ Microsoft.EntityFrameworkCore,6,,,,,,,,,,6,,,,,,
- Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,,,,,15,
+ Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,,,,,,15,
- Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,,,,,45,1
+ Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,,,,,,45,1
- Microsoft.Extensions.Configuration,,,83,,,,,,,,,,,,80,3
+ Microsoft.Extensions.Configuration,,,83,,,,,,,,,,,,,80,3
- Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,,,,,62,
+ Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,,,,,,62,
- Microsoft.Extensions.DependencyModel,,,12,,,,,,,,,,,,12,
+ Microsoft.Extensions.DependencyModel,,,12,,,,,,,,,,,,,12,
- Microsoft.Extensions.FileProviders,,,16,,,,,,,,,,,,16,
+ Microsoft.Extensions.FileProviders,,,16,,,,,,,,,,,,,16,
- Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,,,,,13,2
+ Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,,,,,,13,2
- Microsoft.Extensions.Hosting,,,17,,,,,,,,,,,,16,1
+ Microsoft.Extensions.Hosting,,,17,,,,,,,,,,,,,16,1
- Microsoft.Extensions.Http,,,10,,,,,,,,,,,,10,
+ Microsoft.Extensions.Http,,,10,,,,,,,,,,,,,10,
- Microsoft.Extensions.Logging,,,37,,,,,,,,,,,,37,
+ Microsoft.Extensions.Logging,,,37,,,,,,,,,,,,,37,
- Microsoft.Extensions.Options,,,8,,,,,,,,,,,,8,
+ Microsoft.Extensions.Options,,,8,,,,,,,,,,,,,8,
- Microsoft.Extensions.Primitives,,,63,,,,,,,,,,,,63,
+ Microsoft.Extensions.Primitives,,,63,,,,,,,,,,,,,63,
- Microsoft.Interop,,,27,,,,,,,,,,,,27,
+ Microsoft.Interop,,,27,,,,,,,,,,,,,27,
- Microsoft.NET.Build.Tasks,,,1,,,,,,,,,,,,1,
+ Microsoft.NET.Build.Tasks,,,1,,,,,,,,,,,,,1,
- Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,,,,,4,
+ Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,,,,,,4,
- Microsoft.VisualBasic,,,10,,,,,,,,,,,,5,5
+ Microsoft.VisualBasic,,,10,,,,,,,,,,,,,5,5
- Microsoft.Win32,,,8,,,,,,,,,,,,8,
+ Microsoft.Win32,,,8,,,,,,,,,,,,,8,
- MySql.Data.MySqlClient,48,,,,,,,,,,48,,,,,
+ MySql.Data.MySqlClient,48,,,,,,,,,,48,,,,,,
- Newtonsoft.Json,,,91,,,,,,,,,,,,73,18
+ Newtonsoft.Json,,,91,,,,,,,,,,,,,73,18
- ServiceStack,194,,7,27,,,,,,75,92,,,,7,
+ ServiceStack,194,,7,27,,,,,,75,92,,,,,7,
- System,65,4,12142,,8,8,9,,4,,33,3,1,3,10151,1991
+ System,65,8,12154,,8,8,9,,4,,33,3,1,3,4,10163,1991
- Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,,
+ Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,,,

github-actions[bot] avatar Dec 09 '22 00:12 github-actions[bot]

:warning: The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",4,12142,65,7
+    System,"``System.*``, ``System``",8,12154,65,7
-    Totals,,4,12705,397,7
+    Totals,,8,12717,397,7
  • Changes to framework-coverage-csharp.csv:
- package,sink,source,summary,sink:code,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,summary:taint,summary:value
+ package,sink,source,summary,sink:code,sink:encryption-decryptor,sink:encryption-encryptor,sink:encryption-keyprop,sink:encryption-symmetrickey,sink:html,sink:remote,sink:sql,sink:xss,source:file,source:local,source:remote,summary:taint,summary:value
- Dapper,55,,,,,,,,,,55,,,,,
+ Dapper,55,,,,,,,,,,55,,,,,,
- JsonToItemsTaskFactory,,,7,,,,,,,,,,,,7,
+ JsonToItemsTaskFactory,,,7,,,,,,,,,,,,,7,
- Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,28,,,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,,,,,28,,,,,,
- Microsoft.CSharp,,,24,,,,,,,,,,,,24,
+ Microsoft.CSharp,,,24,,,,,,,,,,,,,24,
- Microsoft.EntityFrameworkCore,6,,,,,,,,,,6,,,,,
+ Microsoft.EntityFrameworkCore,6,,,,,,,,,,6,,,,,,
- Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,,,,,15,
+ Microsoft.Extensions.Caching.Distributed,,,15,,,,,,,,,,,,,15,
- Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,,,,,45,1
+ Microsoft.Extensions.Caching.Memory,,,46,,,,,,,,,,,,,45,1
- Microsoft.Extensions.Configuration,,,83,,,,,,,,,,,,80,3
+ Microsoft.Extensions.Configuration,,,83,,,,,,,,,,,,,80,3
- Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,,,,,62,
+ Microsoft.Extensions.DependencyInjection,,,62,,,,,,,,,,,,,62,
- Microsoft.Extensions.DependencyModel,,,12,,,,,,,,,,,,12,
+ Microsoft.Extensions.DependencyModel,,,12,,,,,,,,,,,,,12,
- Microsoft.Extensions.FileProviders,,,16,,,,,,,,,,,,16,
+ Microsoft.Extensions.FileProviders,,,16,,,,,,,,,,,,,16,
- Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,,,,,13,2
+ Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,,,,,,13,2
- Microsoft.Extensions.Hosting,,,17,,,,,,,,,,,,16,1
+ Microsoft.Extensions.Hosting,,,17,,,,,,,,,,,,,16,1
- Microsoft.Extensions.Http,,,10,,,,,,,,,,,,10,
+ Microsoft.Extensions.Http,,,10,,,,,,,,,,,,,10,
- Microsoft.Extensions.Logging,,,37,,,,,,,,,,,,37,
+ Microsoft.Extensions.Logging,,,37,,,,,,,,,,,,,37,
- Microsoft.Extensions.Options,,,8,,,,,,,,,,,,8,
+ Microsoft.Extensions.Options,,,8,,,,,,,,,,,,,8,
- Microsoft.Extensions.Primitives,,,63,,,,,,,,,,,,63,
+ Microsoft.Extensions.Primitives,,,63,,,,,,,,,,,,,63,
- Microsoft.Interop,,,27,,,,,,,,,,,,27,
+ Microsoft.Interop,,,27,,,,,,,,,,,,,27,
- Microsoft.NET.Build.Tasks,,,1,,,,,,,,,,,,1,
+ Microsoft.NET.Build.Tasks,,,1,,,,,,,,,,,,,1,
- Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,,,,,4,
+ Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,,,,,,4,
- Microsoft.VisualBasic,,,10,,,,,,,,,,,,5,5
+ Microsoft.VisualBasic,,,10,,,,,,,,,,,,,5,5
- Microsoft.Win32,,,8,,,,,,,,,,,,8,
+ Microsoft.Win32,,,8,,,,,,,,,,,,,8,
- MySql.Data.MySqlClient,48,,,,,,,,,,48,,,,,
+ MySql.Data.MySqlClient,48,,,,,,,,,,48,,,,,,
- Newtonsoft.Json,,,91,,,,,,,,,,,,73,18
+ Newtonsoft.Json,,,91,,,,,,,,,,,,,73,18
- ServiceStack,194,,7,27,,,,,,75,92,,,,7,
+ ServiceStack,194,,7,27,,,,,,75,92,,,,,7,
- System,65,4,12142,,8,8,9,,4,,33,3,1,3,10151,1991
+ System,65,8,12154,,8,8,9,,4,,33,3,1,3,4,10163,1991
- Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,,
+ Windows.Security.Cryptography.Core,1,,,,,,,1,,,,,,,,,

github-actions[bot] avatar Dec 09 '22 00:12 github-actions[bot]