Jan Potoms

Results 296 comments of Jan Potoms

Blocked by https://github.com/recharts/recharts/issues/3615 _Technically we could ignore the warning, but that would defeat its purpose. Let's hold off on doing that unless there's something else in 18.3.1 we urgently need_

Just to add to the benchmark, we created a [skeleton for the data grid](https://github.com/mui/mui-toolpad/blob/82635255595a8fd7c3e0222101abd11e06b4ea0e/packages/toolpad-components/src/DataGrid.tsx#L43) in Toolpad. It adds some randomness to the length of the bars, and it respects cell...

> Nice. I wonder do we need a skeleton per cell. The way I understand it is that you'd use a skeleton instead of a spinner to minimize the visual...

> Additionally, the distinction between "caught" and "uncaught" errors in this case doesn't have any substance. It would appear that even wrapping your whole app in one boundary would suddenly...

> Our virtualization needs to measure the dimensions on mount which is not possible with server-side rendering (there's no "mount"). I'm experiencing this as well. Having a dashboard that displays...

> Even though destructuring props may create a new object, mutating the destructured props is still considered a bad practice in React. Why is it bad practice? I assumed the...

🤦 Oh ofcourse, it's about tracking mutations. Makes sense, thanks for explaining.