Jan Potoms

Results 296 comments of Jan Potoms

Regarding the CI issues. It looks like the snapshot size test is looking for the umd build. Which was removed in this PR. We can also get rid of it...

Not going to comment here on the _why now_ (cc @mnajdova @michaldudak), but I can already comment on some of the points made. > 1. The pragmatic thing sounds to...

> OK, I can see this. We could say: we inverse steps 1 and 2 because we have enough "materials" to work with, MUI X and Toolpad are enough. Just...

> @Janpot, could you please help me understand your reluctance to use smaller packages today? _reluctance_ is such a negative word, It's a preference 🙂. a non-exhaustive list of reasons...

I'm making soft arguments. None of them are blocking. You asked me to explain my preference, and these are the reasons why I have this preference 🙂. The main point...

This establishes the @mui/docs package, will move more components incrementally in follow-up PRs

> I'm saying that we could use git submodules to solve the same problem that using npm packages solves today. You need to shape this submodules idea in a more...

> @Janpot My assumption is that from there, we can configure part of /monorepo/ in the MUI X pnpm workspace, have pnpm install the monorepo dependencies. Yes, great answer, thats...

> From the perspective of pnpm, it looks like a normal folder. But ok, maybe there will be bugs when doing a git pull. It looks like a folder that...

I think I ran into this as well [last week](https://github.com/mui/material-ui/pull/40889/files#r1488201255) and increased available memory for this script. But decreasing concurrency will likely work as well _edit: @siriwatknp That PR got...