Jan Potoms

Results 296 comments of Jan Potoms

Would it make sense to remove basic auth from `toolpad-settings` and create a `toolpad-basic-auth` group that we add to the main deployment?

I believe this will be very similar to the postgres datasource. Perhaps it makes sense to create an abstract SQL datasource that we can both base postgres and MySql on?

Another example: https://github.com/mui/mui-toolpad/pull/778/files#diff-e235aa0e73a44734157798060c9962f5b14ae8ecee7e1a295bbb428c9210f41bR58 These are updates to a deeply nested structure that also depend on actual values within. Here it was just easier to deeply clone the object and do...

> As a side effect that I mentioned the other day - we could get undo/redo functionality almost for free with immer Just to note: We already have immutable application...

For me the choice would be between - ELK stack (either on elastic.co or on AWS) and ship logs from within the application - Datadog and ship logs from render.com...

> I imported MUI pagination component and wanted to use the current page number prop from this custom component into my application to render some assets, but couldn't do it....

> Ok, so maybe it's an issue with how I have Docker configured. To verify I'd build an image locally: ```sh docker build \ --progress plain \ -t muicom/toolpad:testing-local \...

We wrap the whole page in a MUI Container. Is this a matter of adding an option on the page to disable that Container? _edit: linking feature request: https://github.com/mui/mui-toolpad/issues/492_

> Another thought, we might be able to minimize the cost of keeping the screenshot script up to date by taking them during the e2e tests. I mean, I think...

Just to note, visual regression testing of these screenshots can potentially be as straightforward as accompanying every `locator.screenshot()` call with a `expect(locator).toHaveScreenshot()` call. Some things that can be tried regarding:...