eclipse-pde-partial-idea icon indicating copy to clipboard operation
eclipse-pde-partial-idea copied to clipboard

Support composite repositories

Open lppedd opened this issue 2 years ago • 6 comments

Following issue #80, an enhancement to simplify Target Platform management could be supporting composite repositories. https://wiki.eclipse.org/Equinox/p2/Composite_Repositories_(new)

Basically two files, compositeContent.xml and compositeArtifacts.xml, explain how to access the - real - children repositories. Personal note: to be honest the two XML files seems identical

lppedd avatar Jul 05 '22 07:07 lppedd

Yeah, content and artifacts seems identical, and those two file under update.site seems too.

Did we add all repository into target in one Location if we select the composite repositories? All repository's bundle and feature were merge into one Location, it will difficult to know the feature was under which repository.

if you don't care, I can add composite repositories support, and it can select the root directory, add all feature and bundle into one Location under children repositories.

JaneWardSandy avatar Jul 05 '22 07:07 JaneWardSandy

@JaneWardSandy I think the only two files you should be looking at are the ones in the root folder.

Reading them, you just "simulate" multiple directories being added, while in reality it's only one. Then in Content, you'll see them separated.

Maybe I'm not explaining very well, let me know

lppedd avatar Jul 05 '22 13:07 lppedd

Ohhhhh wait, now I got what you meant.

So basically we'll be in a situation such that the Composite Repository will me a new tree node in locations. Then inside the node all the real repositories will appear. Is that what you meant?

Let's see if I can do a mockup

lppedd avatar Jul 05 '22 14:07 lppedd

Yes, as you said, this design is more reasonable and more user-friendly. It's just that the scalability of my code writing is not good before, and it is not easy to increase the tree level. I may not consider providing this modification in a short time.

JaneWardSandy avatar Jul 06 '22 01:07 JaneWardSandy

@JaneWardSandy sounds fine. If that is your opinion on the code, what I'll do for 1.4.3, 1.4.4, etc. is just cleaning up the code then.

lppedd avatar Jul 06 '22 07:07 lppedd

Whether it's code cleanup or architecture, or whatever, your help would be greatly appreciated.

The original plan was to think about version 2.0 and complete the refactoring of the entire project, but currently limited by the cognition and development ability of software engineering, I have not been able to start preliminary preparations.

JaneWardSandy avatar Jul 06 '22 07:07 JaneWardSandy