Enable plugin.properties usage

[kriegaex]

In IDEA, I am getting compile errors, because Eclipse plugin manifests can look like this:

Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.aspectj; singleton:=true
Bundle-Version: 2.2.4.qualifier
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Bundle-ActivationPolicy: lazy

Please note the variables %pluginName and %providerName, which come from a plugins.properties file in the module root directory:

pluginName=AspectJ Development Tools
providerName=Eclipse AspectJ Development Tools

It would be helpful if those properties would be resolved correctly during the build.

[JaneWardSandy]

IDEA did not check whether the Header value meets the requirements when compiling Jar Artifacts, and the mandatory checks I made in the plug-in are limited to a few special Headers to report Error-level errors, and others only check that they are not empty characters string.

So I don't quite understand your question. What operation did you take to cause the error report?

[kriegaex]

Moving and renaming the file to that folder seems to help for the IDE build, but I have not tested if the Maven Tycho build still works or not, because I am debugging another problem in the project itself. Anyway, I cannot fully compile my project, because 3 more OSGi-related build problems occur in the same multi-module project. Unfortunately, I only see "osgi: [org.eclipse.aspectj] Unexpected build error" without further explanation. That might be unrelated to PDE Partial or not, I am unsure.

[JaneWardSandy]

At present, I am not doing compatibility between Maven and Gradle. Currently, all functions are implemented based on the IntellIJ Build System(Build -> Build Artifacts...). There may be other problems when Maven and Gradle are used, which are known and not limited to: the code always prompts an error, prompts that the Bundle does not exist, etc.

[kriegaex]

Oh, I see. Well, I am contributing to a Tycho Maven project, so I kind of have no other choice. 😉

[kriegaex]

Moving and renaming the file to that folder seems to help for the IDE build, but I have not tested if the Maven Tycho build still works or not

Update: No, the Tycho build no longer works now, so I had to revert the change, or I have to keep redundant copies in OSGI-INF/l10n/bundle.properties and remember not to commit them.

Besides, after you edited your comment, removing the hint concerning OSGI-INF/l10n/bundle.properties, my responses no longer fit what you said before.

[JaneWardSandy]

That's so strange.

As mentioned above, I didn't restrict internationalization in the plug-in and didn't check the properties file.

Do you want to try to remove the Facet of PDE in the case of a compilation error to see if the compilation still reports an error?