Jan Provazník
Jan Provazník
So the inline tasks can have references. I glossed over that initially thinking the resolution info would be in the dll so calling Assembly.Load on the dll with the task...
Note: currently when you declared task parameters with output/required in xml instead of in code the code that is generated did not contain them and it relied on some. TaskHost...
Note: XamlTaskFactory has no test coverage for runtime of tasks, and the test coverage of RoslynCodeTaskFactory/CodeTaskFactory is not great. It's good that this is opt-in.
IMO this is done and waiting for the threat model review, if the sidecar taskhost pr is reintroduced it would need adjustment again (I reverted it when sidecar taskhost was...
New attempt to move forward: load as bytes, workaround the location in the assembly communication infrastructure. This is supposed to allow deleting the temporary dll on build end which is...
ready for another review after major changes @AR-May
I'm creating 2 exp insertions: one for validating this does not break VS when off - passed one for validating impact on VS when the trait is enabled - expected...
### Before  ### After
scaling back 17.14 effort to usage via VS Experiments, not random sampling: https://github.com/dotnet/msbuild/issues/11348
related: https://github.com/dotnet/msbuild/issues/10189 The three things: "Namespaces x Filesystem x DLLs" should be clarified what goes where, why and what should be moved.