msbuild icon indicating copy to clipboard operation
msbuild copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

pass location information to EventArgs

Open JanProvaznik opened this issue 1 year ago • 2 comments

Fixes #10529

Context

Changes Made

split IMSBuildElementLocation to separate file and added it to Framework .dll (kept in Microsoft.Build.BackEnd namespace, that should be moved eventually if desirable https://github.com/dotnet/msbuild/issues/10544 ) removed location from BuildCheckResult.FormatMessage, location is logged via the filled parameters by Build*EventArgs

Testing

Notes

JanProvaznik avatar Aug 21 '24 13:08 JanProvaznik

Before

image

After

image

JanProvaznik avatar Aug 23 '24 08:08 JanProvaznik

We should check the appearance of the suggestion level as well, but otherwise this feels ready to go!

JanKrivanek avatar Aug 23 '24 10:08 JanKrivanek

It would be nice to have some tests to check if the location is being passed right from the check to the output.

I moved it to a separate ticket: https://github.com/dotnet/msbuild/issues/10581

YuliiaKovalova avatar Aug 29 '24 15:08 YuliiaKovalova