Jan Luca Naumann
Jan Luca Naumann
@Maintainers: I do not really see the reason why the doc generation is failing. In the log I find no error related to this PR?
You could just host a GitHub pages with the corresponding PEP 503 structure. I just wrote a script to generate a index.html for this purpose: ```python #!/usr/bin/env python3 import re...
@skye Would it be possible to have such a GitHub page hosted along the jax repository?
@googlebot I signed it!
The problem is that numpy has already defined for its svd method what happens if the argument has dimension > 2, cf. [1]. I would not suggest to implement a...
> Also optional but nice to have, consider adding some typing. We slowly want to add these across the library. That is nice, I really like the idea to have...
Except for the discussion on the function name, I think I implemented all suggestions and would be fine from my side for another review :)
After some thinking I would go for `higher_order_svd` as function name since this is the name in the literature. Any problems with this name?
Yeah, would be nice to move the general discussion of typing to somewhere else ;) I like typing and as long as it is ok to be included optionally I...
> Just a quick note @JanLuca, here it's fine but try to wait until the end of reviews before doing force-push. It tends to break the link between the review...