Jan-Eric Nitschke

Results 82 comments of Jan-Eric Nitschke

I'll grab the branch and check it out later. But for general thought. We should probably have a an existing version of the matrix stored as a json file. I...

For the CI we are using pre-commit which should run black and ruff for you and then you would have to manually install and run pyright and pylint. Ill try...

We should also definitely make this all type save with type dicts and/or pydantic. Additionally i am currently getting a `JSONDecodeError` when trying to call `round_win_probability`. So we should also...

What is with the `golangci-lint` binary file?

Tests fail because the manual game_rounds do not include that key: https://github.com/pnxenopoulos/awpy/blob/3945c2ee521ef055c921b71883909a71821ec85b/tests/test_stats.py#L182 It might actually make sense to keep that check to not break on old parsed jsons.

It is not currently available but it should be possible to include. If you are interested in adding this, [this](https://github.com/pnxenopoulos/awpy/blob/main/awpy/parser/parse_demo.go) would be the place to do so.

Adjusted `AREA_DIST_MATRIX` to have integer keys instead of str keys (str(integer)) to avoid the needless conversions. This is backwards incompatible for people who are using them from a pervious version....

Ok, i experimented a bit more and it seems that this is actually related to https://github.com/HSF/phoenix/issues/633 a bit. It seems that the label colors are not saved with the labels,...

I would like to reiterate the desire for this feature (and/or also https://github.com/HSF/phoenix/issues/581). I tried to emulate a device with a higher resolution and take a better screenshot with that...

Yeah, i did, both with https://phoenixatlas.web.cern.ch/PhoenixATLAS/ as well as cloned and run locally. I can do the preset 3860 by 2610 but that still looks quite rough to me when...