Jan Ehrhardt

Results 110 comments of Jan Ehrhardt

Works with my version of PHP 7.4.25 NTS x64. See https://phpdev.toolsforresearch.com/php-7.4.25-nts-Win32-vc15-x64.htm https://phpdev.toolsforresearch.com/php-7.4.25-nts-Win32-vc15-x64.zip More info: https://www.apachelounge.com/viewtopic.php?t=6359 pecl_http success : object(http\Client)#1 (4) { ["observers":"http\Client":private]=> object(SplObjectStorage)#2 (1) { ["storage":"SplObjectStorage":private]=> array(0) { } }...

Loads OK with a lot of extensions: [PHP Modules] apc apcu bcmath calendar Core ctype curl date dom ereg ffmpeg filter gd hash http iconv intl json libxml mbstring mcrypt...

Bug reproduced for PHP 8.0 x64 and PHP 8.1 x64. I seem to have success by removing these 3 lines. On git HEAD for PHP 8.1: ``` diff --git a/src/php_http_client_curl.c...

Possibly related: https://stackoverflow.com/questions/61650504/use-of-undefined-constant-curlopt-tcp-fastopen

With https://phpdev.toolsforresearch.com/php-8.0.12-nts-Win32-vs16-x64.htm https://phpdev.toolsforresearch.com/php-8.0.12-nts-Win32-vs16-x64.zip D:\phpdev\php80nts.x64>php -v PHP 8.0.12 (cli) (built: Oct 22 2021 02:44:08) ( NTS Visual C++ 2019 x64 ) Copyright (c) The PHP Group Zend Engine v4.0.12, Copyright (c)...

https://github.com/curl/curl/blob/823d3ab855c55e26d595cfda1a13814baa0f684c/docs/TODO#L389-L393 1.24 TCP Fast Open for windows libcurl supports the CURLOPT_TCP_FASTOPEN option since 7.49.0 for Linux and Mac OS. Windows supports TCP Fast Open starting with Windows 10, version 1607...

See this issue as well with respect to `tcp_fastopen`: https://github.com/curl/curl/issues/3662

Fixed for PHP 8.1 by https://github.com/m6w6/ext-http/commit/86b8a4396d03ad6161ba3d05dd4986521ec7e182

TSRMLS_CC and TSRMLS_DC did not do anything anymore in PHP7 anyway, so they can be safely removed. Patch is easy: ``` diff --git a/jsmin.c b/jsmin.c index 2744aef..773dc09 100644 --- a/jsmin.c...