Jamie Magee

Closed in #217

We should also add some test cases to [verification tests](https://github.com/microsoft/component-detection/tree/main/test/Microsoft.ComponentDetection.VerificationTests/resources)

This is definitely an area where we can improve the first run experience, and I hope to merge #37 soon. The `--project` flag for `dotnet run` expects a `.csproj` file...

It's not required. Can you share your `pom.xml` so I can help debug this more?

I am able to get an output when scanning that directory. Do you have the `mvn` CLI installed? We use it to generate a list of dependencies https://github.com/microsoft/component-detection/blob/2956bdb4cd22eb58292801afcae0ea10d269f619/src/Microsoft.ComponentDetection.Detectors/maven/MvnCliComponentDetector.cs#L35-L39 Here's the...

Thanks for the explanation. MITRE seems to have a pretty broad license[^1] and explicitly allows derivative works and sublicensing: > MITRE hereby grants you a perpetual, worldwide, non-exclusive, no-charge, royalty-free,...

We discussed this on our side, and we should be using the standard `CancellationToken` pattern[^1] if possible. From your side you will create a `CancellationTokenSource`, add a timeout, and provide...

The `required_conversation_resolution_level` now has a different type in the `BranchProtectionRule` https://github.com/octokit/webhooks/blob/5d5bb3ca635b7224a591898321d1a5bad67af3b2/payload-types/schema.d.ts#L440 and `BranchProtectionRuleEditedEvent` https://github.com/octokit/webhooks/blob/5d5bb3ca635b7224a591898321d1a5bad67af3b2/payload-types/schema.d.ts#L824-L826

That sounds reasonable, and it's effectively what I did in the .NET version. I think you will also need a `BranchProtectionRuleNumber` as well though: https://github.com/octokit/webhooks/blob/5d5bb3ca635b7224a591898321d1a5bad67af3b2/payload-types/schema.d.ts#L421

@NoelCross could you merge this if you're happy with the changes? I don't have permissions in this repository.