Jamie

Results 51 comments of Jamie

Ok if I get a chance to try, will report back.

@ittaiz this diff: https://github.com/Jamie5/rules_scala/commit/3f3a79d59fc129b95dd0b0fff20352e8b17817d2 seems to improve things - whereas `bazel test //test/src/main/scala/scalarules/test/scala_import/...` failed on just https://github.com/bazelbuild/rules_scala/commit/a76792b99bc4470819340051973007adb6f9e49a , it now succeeds. Not everything is perfect - `bazel test //third_party/...` fails...

@ittaiz in case the notification was missed (rather than that you're too busy right now, which would be very much understandable even if we weren't in these current circumstances), does...

Haha makes sense, I'm taking a few days off work to take a nice relaxing vacation in my living room. Am not very familiar with this, I could try to...

PR here for you to investigate: https://github.com/bazelbuild/rules_scala/pull/1037 as future time somewhat limited

So due to (voluntary) unemployment might have some time to look at this further, in case you haven't already done so. Though the dev environment setup is somewhat annoying so...

Might also be nice to be able to pass `clip` directly or if it's possible, pass an element directly instead of via selector.

@Quramy would this be something that might happen soon or would you advise forking and doing similar to above?

https://github.com/remix/storycap/pull/3/files is a similar way to do things, in which we manually specify the bounding box (which may have its uses, especially when the actual screenshot-taking code is wrapped in...

https://github.com/Jamie5/storycap/pull/1/commits/cff4d388903cebc908d2ebe2e3f7ba156af707ba works, though I imagine you would prefer to not just expose things on window itself. If this general feature is something you'd like to have I can work on...