JamesWekel

Thank you for the review and the list of requested changes. Every interaction is a learning opportunity e.g. there is an option in VS Code for "Trim Trailing Whitespace" that...

Fish, As I still consider myself as a newbie to Hercules development, I thought that I might focus my newbie eyes on this issue rather than just on instruction performance....

This issue is a QDIO problem with "QEBSM" instructions: `SQBS` (Set Queue Buffer State) and `EQBS` (Extract Queue Buffer State). Based on the current zLinux source at: * https://github.com/torvalds/linux/blob/master/drivers/s390/cio/qdio.h *...

Fish, Based on your historical review, I've updated the patch to fix the comment discrepancy, remove my FIXME comments, fix the CC when rc=97 for `EQBS`, and ensure a default...

Fish, I completely agree with your analysis. The zLinux code (switch statement) only shows what return codes or a 'default' are checked. All we have is the executed code and...

Fish, > Oh come on! You're joking, right? No.. the state check loop is ``` state = nextstate = ARCH_DEP(wfetchb)((VADR)(slsba+bidx), USE_REAL_ADDR, regs); while(count && state == nextstate) { if (autoack)...

Fish, After some more review of the zLinux code for the `EQBS` usage and **next buffer state different** comment, the routine 'get_buf_states' (which calls 'qdio_do_eqbs' ( `EQBS`)) has non-EQBS code:...

Fish, Are we going down a rat hole... To fix the immediate 'Maximum load on qeth card crashes Linux qdio driver' problem, only SQBS need to be modified to return...

It's a bit early as I just tied a build on my Raspberry PI 5 (Armbian Jammy Linux) with Bill's Hercules-helper script. The build failed. 1. there were hundreds of...

Fish, Hercules-helper builds the sharedvfp branch but still get a lot of warning messages. The multi-line comment warnings are still issued; eg. ``` CC transact.lo In file included from ../machdep.h:40,...