James Brown

Results 53 issues of James Brown

- Create a new ERC721 type, ERC721_Enumerable (in ```ContractType```). - Check if the ERC721 contract has the Enumerable interface (```TokenRepository```, find the correct value for ```INTERFACE_ERC721ENUMERABLE```). ```bytes4 private constant _INTERFACE_ID_ERC721_ENUMERABLE...

This is a large-ish project to optimise storage of tokens esp for multi-wallet apps. It also has a number of other advantages eg new wallets benefit from previous wallet's discovered...

Enable Transaction Log pickup for ERC20 Tokens. You can search for Approve, Transfer and common other DeFi events. Check out the implementation in ERC721Token and ERC1155Token and do something along...

Free for all

This is required to put a lower bound on how far down to pickup log events. The most obvious approach is to use the Etherscan (etc) Transaction fetch API in...

Free for all

To reproduce: 1. Send some rinkeby (etc) to another address. 2. After the transaction completes, click on the 'show transaction details' and be taken to ERC20DetailActivity, TokenActivityFragment. 3. Notice that...

Completely decouple the UI elements from all the fetches. - After each API/contract call, check to see if Realm needs updating and update if required. - have a Realm listener...

Many entries in the Activity pane could be transfers or mints of NFTs. If they are, the ```TransferHolder``` entry is used. If the transfer or mint is an NFT, can...

The provider we have been using up to now should be considered as legacy now; it's not worth spending much more time on it. MetaMask and other providers have changed...

Refactor WalletConnectActivity, WCClient and WalletConnectService to remove the OKHttp client from WCClient and move ownership of all WC comms into WalletConnectService. Currently, because the OKHttp client is created in WalletConnectActivity,...

The AddressBook enhancement needs to be added to the InputAddress component: https://app.zeplin.io/project/5d088205bff2d15de6a4397b/screen/5e21a0f6af7b8d2e33cfad76 Here's the AddressBook screen detail: https://app.zeplin.io/project/5d088205bff2d15de6a4397b/dashboard?q=address Ideally the AddressBook Activity is hooked to the InputAddress component, so by...

For Review