alpha-wallet-android icon indicating copy to clipboard operation
alpha-wallet-android copied to clipboard

Add AddressBook to InputAddress component

Open JamesSmartCell opened this issue 5 years ago • 4 comments

The AddressBook enhancement needs to be added to the InputAddress component:

https://app.zeplin.io/project/5d088205bff2d15de6a4397b/screen/5e21a0f6af7b8d2e33cfad76

Here's the AddressBook screen detail:

https://app.zeplin.io/project/5d088205bff2d15de6a4397b/dashboard?q=address

Ideally the AddressBook Activity is hooked to the InputAddress component, so by dropping in the InputAddress component you have access to the addressbook without needing to add anything to the host activity.

The addressbook should be switchable from the layout via a custom:addressbook="true" kind of control, and should default to false so it's only added where needed. Looks like it should be added into SendActivity and TicketTransferDetailActivity. I haven't seen any other places it should be added.

It may also need an entry in the settings page; check the zeplin spec.

You should work off the 'Component Upgrade' branch, as the new components are on that one.

JamesSmartCell avatar Nov 16 '20 22:11 JamesSmartCell

@asif-finimble you'll have to check in Zeplin to see if the design has changed since the issue was created.

Do you have access to Zeplin?

JamesSmartCell avatar Feb 04 '22 04:02 JamesSmartCell

@asif-finimble you'll have to check in Zeplin to see if the design has changed since the issue was created.

Do you have access to Zeplin?

Yes, I have access to Zeplin. Will check it out.

asif-finimble avatar Feb 04 '22 04:02 asif-finimble

@JamesSmartCell I think the AddressBook is not implemented, is it? I cant find any branch for it. I remember implementing this in Bartercard.

asif-finimble avatar Feb 04 '22 10:02 asif-finimble

@JamesSmartCell , for EditAddress Screen, we should allow user to edit only name right? Because Address -> name is 1-1 relationship. Also address is primary key here.

asif-finimble avatar Feb 15 '22 04:02 asif-finimble