James Taylor comments

Repositories
Issues
Comments

Results 33 comments of


                                            James Taylor

More predicate pushdown in ClickHouse connector

Is pushdown for TIMESTAMP types complete? See [here](https://trinodb.slack.com/archives/CP1MUNEUX/p1635356674095500) for more context.

[OMID-102] Support for user Filter when using coprocessor for snapshot filtering

This is great, @yonigottesman! Do the Phoenix unit tests FlappingTransactionIT.testInflightUpdateNotSeen() and testInflightDeleteNotSeen() pass with this change? You can try running them from the omid2 feature branch.

[OMID-102] Support for user Filter when using coprocessor for snapshot filtering

Nice work, @yonigottesman. I made a few minor comments, @ohadshacham. My main question is do the Phoenix unit tests FlappingTransactionIT.testInflightUpdateNotSeen() and testInflightDeleteNotSeen() pass with this change? You can try running...