phoenix-omid icon indicating copy to clipboard operation
phoenix-omid copied to clipboard
verified publisher icon apache

[OMID-102] Support for user Filter when using coprocessor for snapshot filtering

Open yonigottesman opened this issue 7 years ago • 3 comments

yonigottesman avatar Jul 25 '18 06:07 yonigottesman

This is great, @yonigottesman! Do the Phoenix unit tests FlappingTransactionIT.testInflightUpdateNotSeen() and testInflightDeleteNotSeen() pass with this change? You can try running them from the omid2 feature branch.

JamesRTaylor avatar Aug 01 '18 15:08 JamesRTaylor

Nice work, @yonigottesman. I made a few minor comments, @ohadshacham. My main question is do the Phoenix unit tests FlappingTransactionIT.testInflightUpdateNotSeen() and testInflightDeleteNotSeen() pass with this change? You can try running them from the omid2 feature branch in Phoenix against the phoenix-integration branch in omid2 with your patch applied.

JamesRTaylor avatar Aug 06 '18 15:08 JamesRTaylor

All FlappingTransactionIT tests pass and i added a test that will pass only if snapshot filtering is done in a coprocessor before user filter is called

yonigottesman avatar Aug 07 '18 09:08 yonigottesman