James O'Hea comments

Repositories
Issues
Comments

Results 3 comments of


                                            James O'Hea

User memory traj buffer

Looks good overall. I just suggest a few extra comments to explain the data structure. Thanks

Expose powerpmac ssh port

0 isn't a valid ssh port number. The check will need to be from 1 to 65535

Expose powerpmac ssh port

I think the documentation should live inside the pmac repo so it is available for anyone who clones the driver. I see there is already a docs folder. I would...