James Newton-King

Results 646 comments of James Newton-King

@kalduzov The change is merged. It will take a while for it to be released, but you can try out a prerelease version on the NuGet feed - https://github.com/grpc/grpc-dotnet#grpc-nuget-feed

I think the gRPC client should include te=trailers header. That's what grpc-dotnet does: https://github.com/grpc/grpc-dotnet/blob/f4148e8833dcedf8ef13b0817c0fc1c036921f7e/src/Grpc.Net.Client/Internal/GrpcCall.cs#L970-L972

When I asked on chatgpt: > The HTTP/2 spec says a client must send TE: trailers to indicate it is willing to accept trailers. (Unlike HTTP/1.1, in HTTP/2 only the...

You're right that the current behavior today isn't great for streaming. It should be improved. I don't know the right way to implement this. I need to research. Because this...

Thank you for creating a PR. I need to test this thoroughly and write unit tests. I'm sure it works for calls that successfully read to the end of the...

I don't believe this is possible without changes to HttpClient.

`application/grpc-web+proto` is the same as `application/grpc-web`. I don't understand what you're asking.

Could you provide some more details. Is the client sending `application/grpc-web+proto` and the server fails? Or is the server sending `application/grpc-web` which causes the client to fail? What are the...

You could add a delegating handler to work around this issue. The handler would get the content-type to the value you need. Just ensure it runs after `GrpcWebHandler`. I think...

The problem for this user was content negotiation: https://learn.microsoft.com/en-us/aspnet/core/grpc/aspnetcore?view=aspnetcore-8.0&tabs=visual-studio#protocol-negotiation There is nothing specific about docker to their problem. They just happened to be using TLS locally (which did content negotiation)...