James Newton-King
James Newton-King
> That results in the addition of db.name, db.user, server.address and server.port being set on the spans. `db.name` and `db.user` aren't standard parameters. Making them opt-in makes sense. `server.address` and...
I don't think we should add Prometheus/Grafana to the eshop sample in this repo. There is a sample at https://github.com/dotnet/aspire-samples/tree/main/samples/Metrics that uses these containers. When that repo gets this change...
Are you seeing this on your local machine when running the Aspire app host project? Could you upload a simple repo to GitHub? I can take a look and see...
As someone who is writing a UI tool for OTEL data, having a shared generic value to indicate where the client is calling is useful. For now, Aspire will continue...
+ @davidfowl > Semantic conventions are in feature freeze, how would we handle the changes if .NET8.0 is released before stable release of semantic conventions? My opinion: If breaking changes...
@antonfirsov Please take a look
APIs to remove logging are in Microsoft.Extensions.Http 8.0 and greater: See https://github.com/dotnet/runtime/issues/77312#issuecomment-1631264572 You want to call `RemoveAllLoggers` when configuring the OTLP/HTTP clients. You can write more reflection in [`TryEnableIHttpClientFactoryIntegration`](https://github.com/open-telemetry/opentelemetry-dotnet/blob/8cc51b8bca1e26c23a6aff3aae93ec8080a68b8d/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptionsExtensions.cs#L228) to...
You're right that it can't happen in that location. Configuration could be added to the app to disable logging, but logging OTLP HTTP requests at an info level doesn't seem...
I think that's the important thing here: **Exporting telemetry shouldn't generate new telemetry unless there is an error.**
Extra configuration shouldn't be required for this to be usable.