James Messinger

Results 225 comments of James Messinger

@bcherny - Example A in [@dherges' post](https://github.com/bcherny/json-schema-to-typescript/issues/132#issuecomment-345051884) isn't supported by json-schema-ref-parser. It's technically not a valid JSON Schema, since a JSON Reference object is _only_ allowed to have a `$ref`...

This library doesn't provide any routing functionality.

The [current mock-data generation code](https://github.com/BigstickCarpet/swagger-express-middleware/blob/c588f834cdf5b62e60ae21dec7771b2a07458553/lib/helpers/json-schema.js#L143-L148) is far too simplistic and will need to be enhanced. Currently, it just generates random values based on the data type, min/max length, and min/max...

Hi. This behavior is by design, as documented [here](https://github.com/BigstickCarpet/swagger-express-middleware/blob/master/docs/middleware/mock.md#default-and-example-responses). The mock middleware will use the `default` if one exists, or the `example` otherwise.

oh... now _that's_ not by design. It definitely shouldn't be doing that.

Swagger Express Middleware does not support OpenAPI 3.0 yet. The code that you pointed out above is for OpenAPI 2.0 (fka "Swagger")

Awesome, thanks! I'll take a closer look at it this weekend or early next week and get it merged in.

Sorry, I haven't had a chance to take a look at this yet. I'm currently working on a refactoring of [Swagger Parser](https://github.com/BigstickCarpet/swagger-parser), which will have upstream effects on Swagger Express...

Hi @meytal127. Thanks for the PR, but can you please explain the issue that it fixes? It's not clear to me why there should be special handling of `null` values...

@meytal127 - Ah, I see what you're talking about. However, there are two problems with this fix. 1) It only fixes it for `type: "object"`, not for other types, which...